-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird resizing of previews on Media Recording screen #691
Comments
No problem, got it! |
Is this still happening? I only tried a blind fix. |
It is still happening in 3.12.3 |
Now that I have the IDE set up on my Mac I thought I'd look into this. I see where you attempted to fix it with the overrides but when I try to debug those are never entered. |
Right, that would be awesome. So much easier when you are on the actual operating system :) |
Any suggestions on how to approach? I see what you tried to do but I'm not sure why the overrides you put in aren't working? |
Let's go the cheap way: disable the responsive preview panel and use a fix width. Worst case is is that the user needs to scroll horizontal.
|
Okay, this is odd. I unchecked "Cache Shape" in scenebuilder for the highest level border pane on the screen-recorder-panel.fmxl. It seemed to fix it, but I wanted to verify so I got the latest on everything. Before I unchecked it again, it doesn't seem to be happening anymore. I'm going to wait until the next build to see if I can replicate again. |
I found the problem. In the refresh method of the ScreenRecorderPanelController. I narrowed it down to here. With those commented out, it works great but the image from the server is small and doesn't resize. So, the issue is definitely in how those are resizing. I've tried a bunch of ways to fix it, but I think I'm missing a piece about how it's working because my fixes aren't having an impact. |
Just leaving this as a note to look into more as an option - https://www.reddit.com/r/JavaFX/s/Q4vyETVx3A |
Okay, I'm not sure how to fix this. The issue is in the refresh method.
|
Saw your release note, it's still there. I think maybe just putting it in an AnchorPane will help I tested that and it seemed to work. I did the edits on my dev environment for your main repository but my repository is all screwed up so I can't make a pull request. |
On MacOS
If the app isn't set to full screen, when you click over to the media recording screen the preview half of the screen resized very slowly.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should resize quicker and smoother.
Video of issue attached. Sorry it's fuzzy, I had to export as 480p to get under file size limit
Screen.Recording.Trimmed480.mov
The text was updated successfully, but these errors were encountered: