[Bug] Fix Server Performance Issues #703
Comments
|
Just wondered if there has been any development with this issue.. |
|
Not yet. With the 3.12.4 a major problem with the general loading of tables has been fixed and we often switch to other tickets when we are in the mood for them. |
|
Thank you for the update.
…On Mon, Jan 27, 2025 at 1:03 AM Matthias Faust ***@***.***> wrote:
Not yet. With the 3.12.4 a major problem with the general loading of
tables has been fixed and we often switch to other tickets when we are in
the mood for them.
I get that this one is annoying and will prioritize this.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KPOCZYF72LLDGGCZ332MUIPFAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGUYDOMBUGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@spaceangel1970 This would give me some more insights how much better the performance is now. |
|
I dont think much has changed, my logs are attached.
Thank You
…On Sun, Feb 2, 2025 at 5:59 PM Matthias Faust ***@***.***> wrote:
@spaceangel1970 <https://github.com/spaceangel1970>
The 3.12.5 release should bring improvements regarding the speed of the
server start.
Could you re-attach your vpin-studio-server.log here?
This would give me some more insights how much better the performance is
now.
I'm not sure if the given changes are sufficient for general table reload.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KKMK2PXZHMI3MWAHG32NXT7HAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGMZDIOJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry, the attachment as email doesn't seem to work. Can you attach it on the issue directly? Yes, the recent changes mostly improve the startup speed, not the table (re)load speed. Another question regarding this: In the validation settings, are the PUP Pack and ALTSound validators enabled? If that's the case, please disable them. Thank you for your help here! |
|
Attached log files... |
|
Sent in GitHub
…On Mon, Feb 3, 2025, 4:27 PM Matthias Faust ***@***.***> wrote:
Sorry, the attachment as email doesn't seem to work. Can you attach it on
the issue directly?
Yes, the recent changes mostly improve the startup speed, not the table
(re)load speed.
That's why I leave this ticket open and want to continue there.
Another question regarding this: In the validation settings, are the PUP
Pack and ALTSound validators enabled? If that's the case, please disable
them.
Thank you for your help here!
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KK63N5ZWHIEHTCMSGT2N4R77AVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZQGI3DSMRRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Some stats:
The initial startup time has been reduced and also the PUP pack and ALT sound detection. I think the main problem is that it still takes ~9 seconds to load all tables, right? |
|
Awesome, thanks for the update! Much appreciated I can update tables
directly on the cab but not remotely.
…On Wed, Feb 5, 2025, 4:16 AM Matthias Faust ***@***.***> wrote:
Some stats:
- Loading of 129 ALTSounds finished, took 7842ms.
- Finished PUP pack scan, found 278 packs (10708ms)
- Game fetch for emulator -1 took 8757ms / 1180 games / 7ms avg.
- Started VPinStudioServer in 37.937 seconds (JVM running for 39.41)
The initial startup time has been reduced and also the PUP pack and ALT
sound detection.
The general loading time of all tables went down to 7ms.
I think the main problem is that it still takes ~9 seconds to load all
tables, right?
So a complete refresh like it is done right now can be annoying.
I'll see if I can squeeze out more.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KIOH6MQZ4TKP5G3YX32OENZTAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZUHE3DQNRVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Not remotely? You get no connection? You use a macOS client? |
|
Sorry i will explain in more detail. I am using Windows 11.
When i am on my cab everything is running ok. When i am remoting from
laptop to cab i can still do almost everything, except when i update tables
the Table Data Manager does not load and hangs with everything running
100%. At that point i have to force close Studio. It does this every time
and is not usable for this function, so i have just been working directly
on the cab.
Hope this helps and explains things a bit better.
…On Wed, Feb 5, 2025 at 8:29 PM Matthias Faust ***@***.***> wrote:
Not remotely? You get no connection? You use a macOS client?
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KJWPRJ6XTVPFNEJWE32OH7ZVAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZWGU4TSOBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It does indeed wasn't aware of this. |
|
I could reproduce this. |
|
Sorry to report the new update did not fix my issue, i have attached logs for your reference. |
|
Mmh, sorry to hear that. I tried remote connect but only have a Win laptop on my hand. I will also ask another developer of us who owns a mac if he can reproduce this. |
|
Ok, thanks.
…On Fri, Feb 7, 2025 at 3:10 PM Matthias Faust ***@***.***> wrote:
Mmh, sorry to hear that. I tried remote connect but only have a Win laptop
on my hand.
The 3.12.7 patch I deployed today should provide more logging to tackle
this problem.
The main issue is, that there seems to be one request to the server that
block everything and because it blocks, the actual call is not logged 'cos
it never finishes.
I will also ask another developer of us who owns a mac if he can reproduce
this.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KPUCYFUR5TTP7JVZCL2ORL6XAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBSGEYDKMRQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@spaceangel1970 I'd like to look into this. I want to make sure I have the details correct. Server/Cabinet Remote Laptop Client Thanks. |
|
No, it's not.
i don't have Mac OS mine is win11 on both.
…On Sat, Feb 8, 2025 at 12:19 AM gonzonia ***@***.***> wrote:
@spaceangel1970 <https://github.com/spaceangel1970> I'd like to look into
this. I want to make sure I have the details correct.
*Server/Cabinet*
Windows 11
Vpin-Studio version?
*Remote Laptop Client*
Mac OS?
Vpin-Studio version?
Thanks.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KMFE5DBUQ3YXLBQHQD2OTMJBAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBTGM4DGMZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have updated to Version 3.12.7 and attached the log files. |
|
Can you upload the log from the client too? It should be in the file where the app was installed. |
|
Yes, I can, please find the files attached.
Thank You.
…On Sat, Feb 8, 2025 at 6:41 AM gonzonia ***@***.***> wrote:
Can you upload the log from the client too? It should be in the file where
the app was installed.
I see an error in the ui-logs but that's from Feb. 1 and 3.12.6
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KLG7L3GSK3AK3U5KWL2OUZBVAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGI3DCMRSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Unfortunately, it didn't come through with the email. Please upload it to Github. |
|
I will resend it.
…On Sat, Feb 8, 2025, 9:15 AM gonzonia ***@***.***> wrote:
Unfortunately, it didn't come through with the email. Please upload it to
Github.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KOFNHETEQOHMWDSOBD2OVLEBAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGQYDGMJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
resent log files attached |
|
Sorry for the confusion guys! I catched a cold and was a bit under the weather yesterday, mixing up this ticket with another one. @gonzonia I'll ping you about the actual issue I wanted to ask your help for. |
|
No worries, thanks for the update!
…On Sat, Feb 8, 2025 at 1:43 PM Matthias Faust ***@***.***> wrote:
Sorry for the confusion guys! I catched a cold and was a bit under the
weather yesterday, mixing up this ticket with another one.
@gonzonia <https://github.com/gonzonia> I'll ping you about the actual
issue I wanted to ask your help for.
@spaceangel1970 <https://github.com/spaceangel1970> I'll continue to look
into this.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KKARPTO52MK3CRUVZT2OWKQTAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGUZDCMJZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
So to narrow down what is broken exactly I created a new Client where the Table Data Dialog does not load all data. You can download and replace the existing VPin-Studio.exe with it. This test client is compatible to the latest release, so you really only have to exchange this file on your remote laptop, no changes on the cabinet required. |
|
ok i will give it a try and report back soon.
…On Sun, Feb 9, 2025 at 6:40 PM Matthias Faust ***@***.***> wrote:
So to narrow down what is broken exactly I created a new Client where the
Table Data Dialog does not load all data.
This way, I can pin down what requests might possible the cause for the
Studio client to stall. I hope you have the patience for that ;)
You can download
https://www.dropbox.com/scl/fi/z4e0w49tn4w9wv759wlqu/VPin-Studio.zip?rlkey=usxyqpv1yjpznjuhgoiknfi2s&st=qylj07ie&dl=1
and replace the existing VPin-Studio.exe with it.
I assume the Table Dialog will open the from the remote client, but some
tabs will be missing.
This test client is compatible to the latest release, so you really only
have to exchange this file on your remote laptop, no changes on the cabinet
required.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KJKYYJERIDC2JAG2A32O4WCFAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGE3TAMJQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please find attached log files from cab and client i didnt know which one was required. |
|
Thanks, I am narrowing it down. Here comes the next attempt: |
|
No problem I'll run it and get back to you.
…On Mon, Feb 10, 2025, 1:27 PM Matthias Faust ***@***.***> wrote:
Thanks, I am narrowing it down. Here comes the next attempt:
https://www.dropbox.com/scl/fi/93i9clchn7hqlobyg6uv5/VPin-Studio.zip?rlkey=wcjc0wjkjubslkkk6ylx1t5nr&st=ym6ji98i&dl=1
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KK7APWSUX2Z2W6VP3L2PA2DJAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWHE2TGMJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please find attached Cab and Client logs for the latest Debug attempt. |
|
Ok, no errors in the log. But did the table data dialog open now? Is the client still crashing? |
|
Yes table data opened with both versions of studio you sent me.
…On Tue, Feb 11, 2025, 2:27 PM Matthias Faust ***@***.***> wrote:
Ok, no errors in the log. But did the table data dialog open now? Is the
client still crashing?
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KKUE2EIUYK5VSNJQ7T2PGJ4HAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZHEYDGOJQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
And didn't crash.
…On Tue, Feb 11, 2025, 5:27 PM LED Arcade ***@***.***> wrote:
Yes table data opened with both versions of studio you sent me.
On Tue, Feb 11, 2025, 2:27 PM Matthias Faust ***@***.***>
wrote:
> Ok, no errors in the log. But did the table data dialog open now? Is the
> client still crashing?
>
> —
> Reply to this email directly, view it on GitHub
> <#703 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEFW6KKUE2EIUYK5VSNJQ7T2PGJ4HAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZHEYDGOJQG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Ok so, the crashing is caused by one of these 4x tabs:
I have created a version now where only the PinVOL tab is disabled. For some reason I assume that's the "bad guy". Please let me know if the version crashes or not. |
|
Ok, I'll check it out.
…On Tue, Feb 11, 2025, 5:57 PM Matthias Faust ***@***.***> wrote:
Ok so, the crashing is caused by one of these 4x tabs:
- Screens Tab
- Score Data Tab
- Auto Renaming Panel
- PinVOL Settings Tab
I have created a version now where only the *PinVOL* tab is disabled. For
some reason I assume that's the "bad guy".
https://www.dropbox.com/scl/fi/qjnk0ojkbc08xvsxkp01o/VPin-Studio.zip?rlkey=u1uu3ddt2zkfnjyuj0wf5h035&st=4zsyyjzr&dl=1
Please let me know if the version crashes or not.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KI7B4QTIRW7LH5IMOD2PHCQ5AVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJQGMYTKMBZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
That worked no crashes, table data dialog opened everyime. |
|
Alright, so we are getting close. Here is the "regular" version now again: If the issue wasn't fixed by accident, the dialog should block/crash again. Could you attach all PinVol****.ini files located in the resources folder of VPin Studio server here? Should be 3x files. |
|
Studio is crashing again and not loading Table Manager, The PinVol files are attached from the cabinet. |
|
Thanks, now that I know the root cause, I hope to deliver a patch soon. |
|
No problem thanks for your patience.
…On Wed, Feb 12, 2025 at 4:39 PM Matthias Faust ***@***.***> wrote:
Thanks, now that I know the root cause, I hope to deliver a patch soon.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KJKOW7CDNSSPSQUS2T2PMCEFAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJTGAYDANJXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I found the cause for the crash. I'm sorry having messed up your config there. The file has ~500.000 entries there, so simply deleting it is the best way to go. |
|
No worries, thanks for the update!
…On Wed, Feb 12, 2025, 4:47 PM Matthias Faust ***@***.***> wrote:
I found the cause for the crash.
The PinVolTables.ini file is 300MB large. I think I have messed up the
file and need to re-visit how this can happen.
In the meantime, just delete the PinVolTables.ini.
I'm sorry having messed up your config there. The file has ~500.000
entries there, so simply deleting it is the best way to go.
I'll provide a fix with the next version, so that this can't happen again.
—
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFW6KJEDTJIJGLWX7KITDL2PMDANAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJTGAYTMOJWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I deleted the ini file and that fixed the problem. I will test it more
tomorrow thanks for your help.
…On Wed, Feb 12, 2025, 6:24 PM LED Arcade ***@***.***> wrote:
No worries, thanks for the update!
On Wed, Feb 12, 2025, 4:47 PM Matthias Faust ***@***.***>
wrote:
> I found the cause for the crash.
> The PinVolTables.ini file is 300MB large. I think I have messed up the
> file and need to re-visit how this can happen.
> In the meantime, just delete the PinVolTables.ini.
>
> I'm sorry having messed up your config there. The file has ~500.000
> entries there, so simply deleting it is the best way to go.
> I'll provide a fix with the next version, so that this can't happen again.
>
> —
> Reply to this email directly, view it on GitHub
> <#703 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEFW6KJEDTJIJGLWX7KITDL2PMDANAVCNFSM6AAAAABUZY7HSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJTGAYTMOJWG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Thanks for your patience here again! |
The text was updated successfully, but these errors were encountered: