-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Playlist Icon Selection/Upload #708
Comments
These icons are only used for the Studio, not the frontend.
You can wheel icons for playlists in the asset manager. Don't they match in size? |
It wasn't difficult to implement (once I traced everything down), but the way I hacked it together slowed things a bit. I'm sure there's a better way if anyone thinks it's worth pursuing. I used the JavaFX Image class to resize it and then applied that to an ImageView to pass back to the label. |
For now, I thought it would be helpful to add Tooltips. Created PR -#740 |
I have an idea of how to implement this but I'm not sure how to make it happen with what's been built (I just don't know where to find all the needed parts and where they should be housed). On loading of the tables also load a list of the playlists in the background and then load their wheel icons into an array with the playlist ID as an index. Size them two ways, 1) small for the labels and 2) larger for the tooltips. Keep that stored away for the main table (and refresh when appropriate (new media added, new playlist added, etc). Also, it may make sense to make it two preferences. 1) Show Wheel Icon in Table and 2) Show Wheel Icon in Tooltip. |
The client has an image cache (client.getCachedImage ... something) that can be used here. Labels have an extra setGraphics method that is cheaper than using an ImageView. You can also start the PR and I can finish the rest. I like the idea. |
It should be straightfoward, but I can't find the right places to put things that doesn't slow stuff down. Some Questions -
. |
Oh, and since label.setGraphics() requires a node, I still have to use an ImageView to apply it. I can't use a straight image. |
Okay, I think I figured out #1. I put it in the loadStudio method so it fills the imagecache at a better spot. This seemed to help. |
Related to this. It might be too much, but would it make sense to display somewhere on the table data management what playlists the table is a part of? |
Right now we're limited to the icons for playlists that are build into VPin Studio.

What if we want more or different ones?
Or could you resize the wheel that's used for the playlist in popper?
The text was updated successfully, but these errors were encountered: