Skip to content

Handle relative imports in volume better #138

Open
@CJ-Wright-Citadel

Description

@CJ-Wright-Citadel

We missed a symbol in this audit: symbol-management/api-match-audit@86803ad#diff-1862b12bad147ad174efa035edb162707e3da82a6c825a11122bff1819c069cfR58

Which is coming from https://github.com/ARM-DOE/ACT/blob/v0.7.2/act/plotting/TimeSeriesDisplay.py

I think the issue is that the initial assignment of symbols via shadow in the per module parse has a miss on the shadows dict.

On approach would be:

  1. we know that all symbols in the volume must either be also in that volume or be exposed as part of the surface area of the module.
  2. We can then see which symbols do not have a matching pair and try to re-point them towards existing symbols. In this case we can see that the volume symbol (utils.data_utils...) is close to the exposed symbol plotting.data_utils...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions