Merge pull request #4 from symflower/register-pattern

Use convenience functions to register languages and models

Author: zimmski

language/golang.go

@@ -15,8 +15,7 @@ import (
 type LanguageGolang struct{}
 
 func init() {
-	l := &LanguageGolang{}
-	Languages[l.ID()] = l
+	Register(&LanguageGolang{})
 }
 
 var _ Language = (*LanguageGolang)(nil)

language/language.go

@@ -1,5 +1,9 @@
 package language
 
+import (
+	pkgerrors "github.com/pkg/errors"
+)
+
 // Language defines a language to evaluate a repository.
 type Language interface {
 	// ID returns the unique ID of this language.
@@ -14,3 +18,13 @@ type Language interface {
 
 // Languages holds a register of all languages.
 var Languages = map[string]Language{}
+
+// Register adds a language to the common language list.
+func Register(language Language) {
+	id := language.ID()
+	if _, ok := Languages[id]; ok {
+		panic(pkgerrors.WithMessage(pkgerrors.New("language was already registered"), id))
+	}
+
+	Languages[id] = language
+}

model/model.go

@@ -1,5 +1,9 @@
 package model
 
+import (
+	pkgerrors "github.com/pkg/errors"
+)
+
 // Model defines a model that can be queried for generations.
 type Model interface {
 	// ID returns the unique ID of this model.
@@ -11,3 +15,13 @@ type Model interface {
 
 // Models holds a register of all models.
 var Models = map[string]Model{}
+
+// Register adds a model to the common model list.
+func Register(model Model) {
+	id := model.ID()
+	if _, ok := Models[id]; ok {
+		panic(pkgerrors.WithMessage(pkgerrors.New("model was already registered"), id))
+	}
+
+	Models[id] = model
+}

model/symflower.go

@@ -10,8 +10,7 @@ import (
 type ModelSymflower struct{}
 
 func init() {
-	m := &ModelSymflower{}
-	Models[m.ID()] = m
+	Register(&ModelSymflower{})
 }
 
 var _ Model = (*ModelSymflower)(nil)