-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuration test for different configurations #224
Comments
There are already quite some config tests: https://github.com/symfony-cmf/RoutingBundle/tree/master/Tests/Resources/Fixtures/config |
if somebody wants to do this, i think the right thing is looking at the code coverage in the Configuration and RoutingBundleExtension classes and you probably mainly notice uncovered sanity checks for invalid configuration. adding tests for those makes sense to avoid regressions. |
@dbu looking at the coverage, I think we have covered it quite well: http://jsbin.com/sozimako/1/quiet |
indeed. @ElectricMaxxx what did you find missing? |
Hmm, most edge cases of the extension aren't covered: http://jsbin.com/sozimako/2/quiet |
ah yeah. all orm things for example. most of this validation should ideally be moved into the Configuration |
I just fixed just a bug with #223 but i think we should go over the configuration and build different config test cases and test them. Btw we should be able to refactor the one or other Exception in an
->thenInvalid()
thing.The text was updated successfully, but these errors were encountered: