Support for converting none existing enums and constants

[alexander-schranz]

I'm using the config transformer to provide all Yaml based config as PHP Based config.

The following project using a enum: https://github.com/symfony/recipes-contrib/blob/b9d7fb6be96bde2225c51e3cdab23f5fa6c2ca10/datana-gmbh/logz-io-handler/1.7/config/packages/datana_logz_io_handler.yaml#L9

The config transformer seemst to validate if that enum exists and so my converting for https://github.com/schranz-php-recipes/symfony-recipes-php-contrib fails currently:

The file "/private/tmp/symfony-recipes-php-contrib/datana-gmbh/logz-io-handler/1.7/config/packages/datana_logz_io_handler.yaml" does not contain valid YAML: The enum "Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1" is not define d at line 9 (near "$host: !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCent ral1"). In Inline.php line 597: The enum "Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1" is not defined at li ne 9 (near "$host: !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1").

Is there a option to not validate existing of constants and enums.

[TomasVotruba]

What code on our side does it trigger?

If it fails on symfony/yaml side, it would have to be fixed there

[alexander-schranz]

I see its the symfony/yaml which fails here.

                            if (!\defined($enum)) {
                                throw new ParseException(\sprintf('The enum "%s" is not defined.', $enum), self::$parsedLineNumber + 1, $scalar, self::$parsedFilename);
                            }

Thinking about if we could regex out all !php/enum and !php/const and do some Evil things like eval('enum ' . $fakeEnumName . ' { case ' . $fakeEnumValue . '; }'); to get this work / make the enum or constants defined 🤔

php -r 'eval(\'enum FakeEnum { case FakeValue; }\'); var_dump(FakeEnum::cases());'

Would you see that as part of symplify/config-transformer ?

[TomasVotruba]

Eval seems not a good way. I've seen it going wrong so many times.

Can you think of sth else, like patching /vendor?

[alexander-schranz]

I think we will lose then the enum information and will get null.

But we maybe could replace the Symfony none yaml specifications hints with strings.

Example in the case of: https://github.com/symfony/recipes-contrib/blob/b9d7fb6be96bde2225c51e3cdab23f5fa6c2ca10/datana-gmbh/logz-io-handler/1.7/config/packages/datana_logz_io_handler.yaml#L9

-      $host: !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1
+      $host: '$ConfigTransformerH$ack !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1'

Then run the converter which ends in:

       'host' => '$ConfigTransformerH$ack !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1'

And replace that with:

-      'host' => '$ConfigTransformerH$ack !php/enum Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1'
+      'host' => Inpsyde\LogzIoMonolog\Enum\Host::EuCentral1

What do you think?

[TomasVotruba]

I've never got to work with enums in YAML configs, so I have no idea.

Could you kick of PR with minimal failing test case and your solution?