Remove NoDuplicatedShortClassNameRule as overly detailed (#133)

symplify · Jun 2, 2024 · 82ad4e3 · 82ad4e3
1 parent 9f47728
commit 82ad4e3
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 355 deletions.
diff --git a/config/configurable-rules.neon b/config/configurable-rules.neon
@@ -1,10 +1,4 @@
 services:
-    -
-        class: Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            toleratedNestingLevel: 2
-
     -
         class: Symplify\PHPStanRules\Rules\ForbiddenNodeRule
         tags: [phpstan.rules.rule]

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 32 Rules Overview
+# 31 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -415,61 +415,6 @@ class SomeClass
 
 <br>
 
-## NoDuplicatedShortClassNameRule
-
-Class with base "%s" name is already used in "%s". Use unique name to make classes easy to recognize
-
-:wrench: **configure it!**
-
-- class: [`Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule`](../src/Rules/NoDuplicatedShortClassNameRule.php)
-
-```yaml
-services:
-    -
-        class: Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            toleratedNestingLevel: 1
-```
-
-↓
-
-```php
-namespace App;
-
-class SomeClass
-{
-}
-
-namespace App\Nested;
-
-class SomeClass
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-namespace App;
-
-class SomeClass
-{
-}
-
-namespace App\Nested;
-
-class AnotherClass
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## NoDynamicNameRule
 
 Use explicit names over dynamic ones

diff --git a/src/Rules/NoDuplicatedShortClassNameRule.php b/src/Rules/NoDuplicatedShortClassNameRule.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/OneMoreNested/SameShortName.php b/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/OneMoreNested/SameShortName.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/SameShortName.php b/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/SameShortName.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/SkipAlreadyExistingShortName.php b/tests/Rules/NoDuplicatedShortClassNameRule/Fixture/SkipAlreadyExistingShortName.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/NoDuplicatedShortClassNameRuleTest.php b/tests/Rules/NoDuplicatedShortClassNameRule/NoDuplicatedShortClassNameRuleTest.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/Source/SkipAlreadyExistingShortName.php b/tests/Rules/NoDuplicatedShortClassNameRule/Source/SkipAlreadyExistingShortName.php
diff --git a/tests/Rules/NoDuplicatedShortClassNameRule/config/configured_rule.neon b/tests/Rules/NoDuplicatedShortClassNameRule/config/configured_rule.neon