Skip to content

Commit 82ad4e3

Browse files
authored
Remove NoDuplicatedShortClassNameRule as overly detailed (#133)
1 parent 9f47728 commit 82ad4e3

File tree

9 files changed

+1
-355
lines changed

9 files changed

+1
-355
lines changed

config/configurable-rules.neon

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
services:
2-
-
3-
class: Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule
4-
tags: [phpstan.rules.rule]
5-
arguments:
6-
toleratedNestingLevel: 2
7-
82
-
93
class: Symplify\PHPStanRules\Rules\ForbiddenNodeRule
104
tags: [phpstan.rules.rule]

docs/rules_overview.md

Lines changed: 1 addition & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 32 Rules Overview
1+
# 31 Rules Overview
22

33
## AnnotateRegexClassConstWithRegexLinkRule
44

@@ -415,61 +415,6 @@ class SomeClass
415415

416416
<br>
417417

418-
## NoDuplicatedShortClassNameRule
419-
420-
Class with base "%s" name is already used in "%s". Use unique name to make classes easy to recognize
421-
422-
:wrench: **configure it!**
423-
424-
- class: [`Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule`](../src/Rules/NoDuplicatedShortClassNameRule.php)
425-
426-
```yaml
427-
services:
428-
-
429-
class: Symplify\PHPStanRules\Rules\NoDuplicatedShortClassNameRule
430-
tags: [phpstan.rules.rule]
431-
arguments:
432-
toleratedNestingLevel: 1
433-
```
434-
435-
436-
437-
```php
438-
namespace App;
439-
440-
class SomeClass
441-
{
442-
}
443-
444-
namespace App\Nested;
445-
446-
class SomeClass
447-
{
448-
}
449-
```
450-
451-
:x:
452-
453-
<br>
454-
455-
```php
456-
namespace App;
457-
458-
class SomeClass
459-
{
460-
}
461-
462-
namespace App\Nested;
463-
464-
class AnotherClass
465-
{
466-
}
467-
```
468-
469-
:+1:
470-
471-
<br>
472-
473418
## NoDynamicNameRule
474419

475420
Use explicit names over dynamic ones

src/Rules/NoDuplicatedShortClassNameRule.php

Lines changed: 0 additions & 173 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/OneMoreNested/SameShortName.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/Fixture/Nested/SameShortName.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/Fixture/SkipAlreadyExistingShortName.php

Lines changed: 0 additions & 9 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/NoDuplicatedShortClassNameRuleTest.php

Lines changed: 0 additions & 72 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/Source/SkipAlreadyExistingShortName.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoDuplicatedShortClassNameRule/config/configured_rule.neon

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)