Support environment variable for patch output path #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siemova
force-pushed
the
env_patch_output_path
branch
2 times, most recently
from
dcc17cc to
6653769
Compare
siemova
force-pushed
the
env_patch_output_path
branch
from
6653769 to
1ab8a46
Compare
Member
|
The branch seems conflict, could you rebase? Thank you. |
Member
|
Closing for lack of feedback, to keep issue tracker focus on unclear issues that needs our attention. Feel free to send PR with the reproducer 👍 Thank you for understanding 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12 by adding support for environment variable
VENDOR_PATCHES_OUTPUT_PATH. Its value may be absolute, but must ultimately be relative to the repository. If so,PatchFileFactory::createPatchFilePath()will use it; otherwise, it will fall back to the current default path: "patches".Incidentally fixes some directory separators under Windows, and a few typos.