Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Connection and integration button alignment #8047

Open
squakez opened this issue Mar 6, 2020 · 3 comments
Open

Connection and integration button alignment #8047

squakez opened this issue Mar 6, 2020 · 3 comments
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend status/never-stale Marker that this issue should not be marked as stale

Comments

@squakez
Copy link
Contributor

squakez commented Mar 6, 2020

This is a...


[ ] Feature request
[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Description

Apparently connection and integration action buttons are no longer aligned on the right as done through the rest of the application. We should either keep all buttons aligned on the right or on the left.

Left hand buttons

Screenshot_2020-03-06 Connections - Syndesis

Screenshot_2020-03-06 Integrations - Syndesis

Right hand buttons

Screenshot_2020-03-06 Save or Add Step - Syndesis(1)

I have seen this in connection, integration and api provider creation.

@squakez squakez added group/ui User interface SPA, talking to the REST backend cat/bug A bug which needs fixing labels Mar 6, 2020
@gashcrumb
Copy link
Contributor

Yep, the first two are due to the pf4 migration, it appears the pf4 toolbar doesn't have a way to right-justify the buttons in the way the old pf3 toolbar did.

@dongniwang FYI

@dongniwang
Copy link
Contributor

@gashcrumb @squakez thank you both! I'll add this to the PF4 migration doc. We'll have a visual pass before finalizing everything.

@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Jun 5, 2020
@squakez squakez added status/never-stale Marker that this issue should not be marked as stale and removed status/stale Issue considered to be stale so that it can be closed soon labels Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend status/never-stale Marker that this issue should not be marked as stale
Projects
None yet
Development

No branches or pull requests

3 participants