Skip to content

Commit aeba6c7

Browse files
committed
better code for handling error
1 parent 206a461 commit aeba6c7

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/apigateway/router.js

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,26 +77,21 @@ class Router {
7777

7878
async __handleError(event, request, response, error) {
7979
response.code = 500;
80-
if (this.__outputError) {
81-
response.setError('unknown', error.message);
82-
} else {
83-
response.body = {};
84-
response.setError('server', 'internal server error');
85-
}
80+
response.setError('server', this.__outputError ? error.message : 'internal server error');
8681
if (typeof this.__onError === 'function') {
8782
this.__onError(request, response, error);
8883
}
89-
this.__logError(event, request, response, error);
84+
this.__logError(event, request, error);
9085
}
9186

92-
__logError(event, request, response, error) {
87+
__logError(event, request, error) {
9388
this.__logger.log({
9489
level: 'ERROR',
9590
log: {
9691
event,
9792
request: request.request,
98-
response: response.response,
99-
error: error.stack.split('\n').map((trace) => trace.replace(' ', ''))
93+
error: error.message,
94+
stack: error.stack.split('\n').map((trace) => trace.replace(' ', ''))
10095
}
10196
});
10297
}

0 commit comments

Comments
 (0)