Skip to content

Commit f435ab8

Browse files
committed
Add feedURL to DeliveryRecord
1 parent a670424 commit f435ab8

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

src/models/DeliveryRecord.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ const schema = new mongoose.Schema({
66
type: String,
77
required: true
88
},
9+
feedURL: {
10+
type: String,
11+
required: true
12+
},
913
channel: {
1014
type: String,
1115
required: true

src/structs/DeliveryPipeline.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ class DeliveryPipeline {
7777
const channel = feedObject.channel
7878
const data = {
7979
articleID: article._id,
80+
feedURL: feedObject.url,
8081
channel,
8182
delivered: false,
8283
comment: errorMessage
@@ -97,6 +98,7 @@ class DeliveryPipeline {
9798
const channel = feedObject.channel
9899
const data = {
99100
articleID: article._id,
101+
feedURL: feedObject.url,
100102
delivered: true,
101103
channel
102104
}
@@ -116,6 +118,7 @@ class DeliveryPipeline {
116118
const channel = feedObject.channel
117119
const data = {
118120
articleID: article._id,
121+
feedURL: feedObject.url,
119122
channel,
120123
delivered: false,
121124
comment: 'Blocked by filters'

src/tests/structs/int_DeliveryPipeline.test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ describe('Unit::structs/DeliveryPipeline', function () {
4242
_id: 'some id'
4343
},
4444
feedObject: {
45-
channel: 'w4yrh5e'
45+
channel: 'w4yrh5e',
46+
url: 'someurl'
4647
}
4748
}
4849
beforeEach(() => {
@@ -63,6 +64,7 @@ describe('Unit::structs/DeliveryPipeline', function () {
6364
await pipeline.deliver(newArticle)
6465
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
6566
articleID: newArticle.article._id,
67+
feedURL: newArticle.feedObject.url,
6668
delivered: true,
6769
channel: newArticle.feedObject.channel
6870
})
@@ -79,6 +81,7 @@ describe('Unit::structs/DeliveryPipeline', function () {
7981
await pipeline.deliver(newArticle)
8082
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
8183
articleID: newArticle.article._id,
84+
feedURL: newArticle.feedObject.url,
8285
channel: newArticle.feedObject.channel,
8386
delivered: false,
8487
comment: 'Blocked by filters'
@@ -99,6 +102,7 @@ describe('Unit::structs/DeliveryPipeline', function () {
99102
await pipeline.deliver(newArticle)
100103
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
101104
articleID: newArticle.article._id,
105+
feedURL: newArticle.feedObject.url,
102106
channel: newArticle.feedObject.channel,
103107
delivered: false,
104108
comment: error.message

src/tests/structs/unit_DeliveryPipeline.test.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,13 +214,15 @@ describe('Unit::structs/DeliveryPipeline', function () {
214214
_id: 'abc'
215215
},
216216
feedObject: {
217-
channel: 'abaa'
217+
channel: 'abaa',
218+
url: 'someurl'
218219
}
219220
}
220221
const errorMessage = '53e47yu'
221222
await pipeline.recordFailure(newArticle, errorMessage)
222223
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
223224
articleID: newArticle.article._id,
225+
feedURL: newArticle.feedObject.url,
224226
channel: newArticle.feedObject.channel,
225227
delivered: false,
226228
comment: errorMessage
@@ -236,12 +238,14 @@ describe('Unit::structs/DeliveryPipeline', function () {
236238
_id: 'abc'
237239
},
238240
feedObject: {
241+
url: 'bla',
239242
channel: 'abaa'
240243
}
241244
}
242245
await pipeline.recordSuccess(newArticle)
243246
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
244247
articleID: newArticle.article._id,
248+
feedURL: newArticle.feedObject.url,
245249
channel: newArticle.feedObject.channel,
246250
delivered: true
247251
})
@@ -256,12 +260,14 @@ describe('Unit::structs/DeliveryPipeline', function () {
256260
_id: 'abc'
257261
},
258262
feedObject: {
259-
channel: 'abaa'
263+
channel: 'abaa',
264+
url: 'feedurl'
260265
}
261266
}
262267
await pipeline.recordFilterBlock(newArticle)
263268
expect(DeliveryRecord.Model).toHaveBeenCalledWith({
264269
articleID: newArticle.article._id,
270+
feedURL: newArticle.feedObject.url,
265271
channel: newArticle.feedObject.channel,
266272
delivered: false,
267273
comment: 'Blocked by filters'

0 commit comments

Comments
 (0)