Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataLoader swallows original exceptions #74

Open
sebastiandev opened this issue Jul 2, 2019 · 2 comments
Open

DataLoader swallows original exceptions #74

sebastiandev opened this issue Jul 2, 2019 · 2 comments

Comments

@sebastiandev
Copy link

When executing the batch_load_fn if an error occurs, the exception been raised is not the original one, but an Exception which references the original one in its message, like:

Data loader batch_load_fn function raised an Exception: DomainError("Invalid id 'test' in id ",)

My custom exception is a DomainError but it gets lost and re-raised as an Exception

@sebastiandev
Copy link
Author

@syrusakbary is anyone maintaining this library? this error is pretty urgent in order to make this production ready.

@syrusakbary
Copy link
Owner

@sebastiandev if you would like, I'd welcome a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants