We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/kind bug
The version info string is empty:
"version":""
❯ k logs -n mgt-system deployments/caph-controller-manager | grep 'starting manager' Found 4 pods, using pod/caph-controller-manager-5cbd64b89c-4cj8t {"level":"INFO",...,"file":"./main.go:237","message":"starting manager","version":""}
❯ k get -n mgt-system deployments.apps caph-controller-manager -o yaml | grep image: image: ghcr.io/syself/caph:v1.0.0
I think we should use: https://pkg.go.dev/runtime/debug#ReadBuildInfo instead of our current way (LDFLAGS := $(shell hack/version.sh))
LDFLAGS := $(shell hack/version.sh)
Starting from Go 1.24 the BuildInfo will contain the git-commit.
When we use Go 1.24, we should remove our way of getting the git-version, and use something like that:
bInfo, _ := debug.ReadBuildInfo() setupLog.Info("BuildInfo", "version", caphversion.Get().String(), "Main.Version", bInfo.Main.Version)
The text was updated successfully, but these errors were encountered:
remove buildInfo again. Will be done when we have 1.24
795c1e5
See #1553
No branches or pull requests
Uh oh!
There was an error while loading. Please reload this page.
/kind bug
The version info string is empty:
I think we should use: https://pkg.go.dev/runtime/debug#ReadBuildInfo instead of our current way (
LDFLAGS := $(shell hack/version.sh)
)Starting from Go 1.24 the BuildInfo will contain the git-commit.
When we use Go 1.24, we should remove our way of getting the git-version, and use something like that:
The text was updated successfully, but these errors were encountered: