Skip to content

Replace HetznerBareMetalHost "update" call with "patch" to avoid conflict errors #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janiskemper opened this issue Apr 18, 2025 · 0 comments

Comments

@janiskemper
Copy link
Contributor

/kind bug

What steps did you take and what happened:
We observed, that having a conflict error while deprovisioning a HetznerBareMetalHost is very common, as the HetznerBareMetalMachine controller also updates it. This lead to situations, usually under heavy load, where the object completely stopped reconciling.

It is weird that this happened and not really the fault of our "requeue" mechanism, but still, we could avoid this altogether, if we manage to get rid of "update".

What did you expect to happen:
We can avoid errors that lead to the HetznerBareMetalHost reconciling multiple times in the same state, or even stopping to reconcile at all, if we use the patch logic.

Anything else you would like to add:
I don't remember why we used "update" instead of "patch". There was a reason. That reason might be irrelevant by now, as we took this decision years ago. We should still ensure that we don't run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant