Skip to content

Logs of targetCluster Manager should be markred explicitly #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guettli opened this issue Apr 24, 2025 · 0 comments
Open

Logs of targetCluster Manager should be markred explicitly #1592

guettli opened this issue Apr 24, 2025 · 0 comments

Comments

@guettli
Copy link
Collaborator

guettli commented Apr 24, 2025

/kind feature

When you see a log like this, you might think the caph process was shut down:

{"level":"INFO","time":"2025-04-24T11:43:14.773Z","file":"controller/controller.go:235","message":"Shutdown signal received, waiting for all workers to finish","controller":"certificatesigningrequest","controllerGroup":"certificates.k8s.io","controllerKind":"CertificateSigningRequest"}

But that is not the case. A cluster was deleted and the targetClusterManager was stopped.

Logs of the targetClusterManager should have a key-value pair which makes this more explicit, so that developers seeing logs from the targetClusterManager know where the logs coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant