Use r.Recorder.Eventf() like explained in the docs

[guettli]

/kind feature

Current the code uses record.Eventf() (or Warnf()), which uses the cluster-api package record.

The code of Cluster-API does not use that anymore, and the kubebuilder docs align to the cluster-api code:

Each Reconciler has a field "Record" which gets used to create the events:

    if err = (&controller.MyKindReconciler{
        Client:   mgr.GetClient(),
        Scheme:   mgr.GetScheme(),
        Recorder: mgr.GetEventRecorderFor("mykind-controller"), // <<<===
    }).SetupWithManager(mgr); err != nil {
        setupLog.Error(err, "unable to create controller", "controller", "MyKind")
        os.Exit(1)
    }

Docs: https://book.kubebuilder.io/reference/raising-events

Currently, it is too difficult to get the events in unit-tests. After that change, we can easily overwrite the Recorder in tests.