Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a guide how to style third-party libraries #2290

Open
arantespp opened this issue Aug 9, 2022 · 3 comments
Open

Creating a guide how to style third-party libraries #2290

arantespp opened this issue Aug 9, 2022 · 3 comments
Labels
documentation Changes only affect the documentation help wanted Extra attention is needed

Comments

@arantespp
Copy link

Is your feature request related to a problem? Please describe.

We're using Theme UI to create our components library, and we had difficulty understanding how to style third-party libraries—when to use sx, variants, wrapper in a parent Box, using classNames...

Describe the solution you'd like

It'd be interesting if we had a guide with all possible ways to style a third-party library. For example:

The title of the guide could be "Styling Third-Party Libraries."

I can help writing this guide if you think it's interesting to the project.

@ardasevinc
Copy link

I'm also interested in this

@lachlanjc
Copy link
Member

That’d be fantastic! We’d love a contribution of a guide. I’m unlikely to write one myself but happy to review/edit.

@hasparus
Copy link
Member

There are definitely some caveats and mines to step here, so a guide could definitely add some value.

We could also hop on Discord or a Twitter space and chat about it.

I've been solving a lot of useResponsiveValue and useMatchMedia related SSR problems lately.
This wouldn't be a problem in case of your Modal. I think I'd often use a custom CSS property with a responsive tuple like --my-padding: ['$sm', '$lg'] in cases like this. So yeah, definitely an interesting topic.

@lachlanjc lachlanjc added help wanted Extra attention is needed documentation Changes only affect the documentation labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants