Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned tabs that aren't on the list disappear when you click the plugin's icon. #2

Open
christianmagill opened this issue Sep 13, 2021 · 1 comment

Comments

@christianmagill
Copy link

When you pin a tab that's not on your list, it disappears when you click the icon to transfer to the new window.

@christianmagill christianmagill changed the title Pinned tabs that aren't on the list get lost when moving to new window. Pinned tabs that aren't on the list disappear when you click the plugins icon. Sep 22, 2021
@christianmagill christianmagill changed the title Pinned tabs that aren't on the list disappear when you click the plugins icon. Pinned tabs that aren't on the list disappear when you click the plugin's icon. Sep 22, 2021
@szhu
Copy link
Owner

szhu commented Jul 3, 2022

That's currently expected behavior.

The core issue is that the extension has no way to keep track of which pinned tabs were created by the extension that are still being used "as intended" -- as in, there's no way of telling in which pinned tabs the user has started to navigated away from the original pinned "app".

If you or anyone else has thoughts about how to solve this, please let me know.

Until there's a solution to the above, to keep things simple, the current algorithm is:

  • If the number of pinned tabs matches the expected number of pinned tabs, assume all the pinned tabs are still "intact" and don't mess with them.
  • If the number of pinned tabs doesn't match, we don't know exactly what happened, so just remove all the pinned tabs and re-create them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants