Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use docker compose instead of a single docker container #1927

Open
TheDevilOnLine opened this issue Jul 2, 2024 · 3 comments
Open
Labels
🌟 enhancement New feature or request

Comments

@TheDevilOnLine
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A lot of our developers work on Windows and running start-database.sh requires a bunch of extra steps

Describe the solution you'd like to see

start-database.sh suggest running itself in WSL, but I think it would be way easier to supply a docker-compose.yml. This also allows for random password generation to be used in the docker-compose.yml and in the .env file.

Describe alternate solutions

N/A

Additional information

If people are interested in this solution, I can make a pull request with the suggested functionality.

@datasalaryman
Copy link
Contributor

Hi, to clarify, do you see the server and client parts of the nextjs to be separate docker containers? or something else?

@TheDevilOnLine
Copy link
Contributor Author

@datasalaryman just the database (so the stuff that's currently being started into docker when you run the start-database.sh command)

@datasalaryman
Copy link
Contributor

@TheDevilOnLine so the docker-compose file will be structured like this?

services:
  web:
    ...
  postgres:
    ...

okay, I'll see if I can take that on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants