Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use app/globals.css instead of styles/globals.css #2030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use app/globals.css instead of styles/globals.css #2030

wants to merge 1 commit into from

Conversation

ritmillio
Copy link

Closes #2028

✅ Checklist

  • [✅] I have followed every step in the contributing guide (updated 2022-10-06).
  • [✅] The PR title follows the convention we established conventional-commit
  • [✅] I performed a functional test on my final commit

Changelog

This change would streamline development and configuration for the majority of developers who use both the T3 stack and Shadcn UI.

💯

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 74b2f29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved		 Nov 22, 2024 1:53pm

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024

@ritmillio is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@xhemals
Copy link

xhemals commented Nov 29, 2024

Shadcn works fine with the /styles/globas.css for me. It auto finds the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge juliusmarminge is a code owner

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Use app/globals.css instead of styles/globals.css
2 participants
@ritmillio @xhemals