Skip to content

x/vulndb: potential Go vuln in golang.org/x/crypto: GHSA-v778-237x-gjrc #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GoVulnBot opened this issue Dec 11, 2024 · 2 comments
Closed
Assignees

Comments

@GoVulnBot
Copy link

Advisory GHSA-v778-237x-gjrc references a vulnerability in the following Go modules:

Module
golang.org/x/crypto

Description:
Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.

The documentation for ServerConfig.PublicKeyCallback says that "A call to this function does not guarantee that the key offered is in fact used to authenticate." Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key. PublicKeyCallback may be called with multiple keys, and the order in which the keys were provided cannot be used to infer which key the client successf...

References:

Cross references:

See doc/quickstart.md for instructions on how to triage this report.

id: GO-ID-PENDING
modules:
    - module: golang.org/x/crypto
      versions:
        - fixed: 0.31.0
      vulnerable_at: 0.30.0
summary: |-
    Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in
    golang.org/x/crypto
cves:
    - CVE-2024-45337
ghsas:
    - GHSA-v778-237x-gjrc
references:
    - advisory: https://github.com/advisories/GHSA-v778-237x-gjrc
    - fix: https://github.com/golang/crypto/commit/b4f1988a35dee11ec3e05d6bf3e90b695fbd8909
    - fix: https://go.dev/cl/635315
    - report: https://go.dev/issue/70779
    - web: https://groups.google.com/g/golang-announce/c/-nPEi39gI4Q/m/cGVPJCqdAQAJ
source:
    id: GHSA-v778-237x-gjrc
    created: 2024-12-11T23:01:13.790921101Z
review_status: UNREVIEWED

@tatianab tatianab self-assigned this Dec 12, 2024
@tatianab
Copy link
Contributor

Duplicate of #3321, but report needs update with GHSA

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/635695 mentions this issue: data/reports: update GO-2024-3321

smikes pushed a commit to smikes/tailscale-android that referenced this issue Apr 14, 2025
Fixes issue #15680

Fix golang/vulndb#3328
Github GHSA-v778-237x-gjrc

NOTE: there is no known exploit of this code via tailscale
and I do not believe tailscale-android even used the at-risk
code path

Signed-off-by: Sam Mikes (He/him/his) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants