Skip to content

Conversation

@gitttt-1234
Copy link
Collaborator

This PR fixes the weight mapping for legacy top-down ID models. Previously, the legacy mapper didn’t account for linear layers and failed to transpose their weight shapes to match PyTorch’s convention. This update ensures that linear layer weights are correctly transposed and mapped from TensorFlow to PyTorch.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.44%. Comparing base (ff91433) to head (c884e5d).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
sleap_nn/legacy_models.py 92.30% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (92.30%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   95.28%   93.44%   -1.84%     
==========================================
  Files          49       49              
  Lines        6765     7005     +240     
==========================================
+ Hits         6446     6546     +100     
- Misses        319      459     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gitttt-1234 gitttt-1234 merged commit 075e579 into main Sep 25, 2025
7 of 8 checks passed
@gitttt-1234 gitttt-1234 deleted the divya/fix-legacy-models branch September 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants