Skip to content

Commit 731510a

Browse files
committed
Fixing an issue in the integration test
Signed-off-by: Kshitij Tandon <[email protected]>
1 parent 5e9c1c5 commit 731510a

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

src/test/kotlin/org/opensearch/indexmanagement/rollup/interceptor/RollupInterceptorIT.kt

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,12 +1092,12 @@ class RollupInterceptorIT : RollupRestTestCase() {
10921092
},
10931093
"aggs": {
10941094
"sum_passenger_count": { "sum": { "field": "passenger_count" } },
1095-
"max_passenger_count": { "max": { "field": "passenger_count" } },
1096-
"value_count_passenger_count": { "value_count": { "field": "passenger_count" } }
1095+
"max_passenger_count": { "max": { "field": "passenger_count" } }
10971096
}
10981097
}
10991098
""".trimIndent()
1100-
// Search 1 non-rollup index and 1 rollup
1099+
// Search 1 non-rollup index and 1 rollup
1100+
updateSearchRawRollupClusterSetting(false)
11011101
val searchResult1 = client().makeRequest("POST", "/$sourceIndex2,$targetIndex2/_search", emptyMap(), StringEntity(req, ContentType.APPLICATION_JSON))
11021102
assertTrue(searchResult1.restStatus() == RestStatus.OK)
11031103
val failures = extractFailuresFromSearchResponse(searchResult1)
@@ -1118,13 +1118,12 @@ class RollupInterceptorIT : RollupRestTestCase() {
11181118
assertTrue(rawRes1.restStatus() == RestStatus.OK)
11191119
val rawRes2 = client().makeRequest("POST", "/$targetIndex2/_search", emptyMap(), StringEntity(req, ContentType.APPLICATION_JSON))
11201120
assertTrue(rawRes2.restStatus() == RestStatus.OK)
1121-
val searchResult2 = client().makeRequest("POST", "/$sourceIndex2,$targetIndex2/_search", emptyMap(), StringEntity(req, ContentType.APPLICATION_JSON))
1122-
assertTrue(searchResult2.restStatus() == RestStatus.OK)
1121+
val searchResult = client().makeRequest("POST", "/$sourceIndex2,$targetIndex2/_search", emptyMap(), StringEntity(req, ContentType.APPLICATION_JSON))
1122+
assertTrue(searchResult.restStatus() == RestStatus.OK)
11231123
val rawAgg1Res = rawRes1.asMap()["aggregations"] as Map<String, Map<String, Any>>
11241124
val rawAgg2Res = rawRes2.asMap()["aggregations"] as Map<String, Map<String, Any>>
1125-
val rollupAggResMulti = searchResult2.asMap()["aggregations"] as Map<String, Map<String, Any>>
1125+
val rollupAggResMulti = searchResult.asMap()["aggregations"] as Map<String, Map<String, Any>>
11261126

1127-
val trueAggCount = rawAgg1Res.getValue("value_count_passenger_count")["value"] as Int + rawAgg2Res.getValue("value_count_passenger_count")["value"] as Int
11281127
val trueAggSum = rawAgg1Res.getValue("sum_passenger_count")["value"] as Double + rawAgg2Res.getValue("sum_passenger_count")["value"] as Double
11291128

11301129
assertEquals(
@@ -1135,10 +1134,6 @@ class RollupInterceptorIT : RollupRestTestCase() {
11351134
"Searching rollup target index did not return the sum for all of the rollup jobs on the index",
11361135
trueAggSum, rollupAggResMulti.getValue("sum_passenger_count")["value"],
11371136
)
1138-
assertEquals(
1139-
"Searching rollup target index did not return the value count for all of the rollup jobs on the index",
1140-
trueAggCount, rollupAggResMulti.getValue("value_count_passenger_count")["value"],
1141-
)
11421137

11431138
// Search 2 rollups with different mappings
11441139
try {

0 commit comments

Comments
 (0)