Skip to content

Commit 8e9ea7d

Browse files
committed
[new] Enable WebSocket ping timeout by default
1 parent da0a900 commit 8e9ea7d

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

src/taoensso/sente.cljc

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -379,20 +379,7 @@
379379
:or {recv-buf-or-n (async/sliding-buffer 1000)
380380
ws-kalive-ms (enc/ms :secs 25) ; < Heroku 55s timeout
381381
lp-timeout-ms (enc/ms :secs 20) ; < Heroku 30s timeout
382-
383-
;; TODO Default initially disabled since it can take some time
384-
;; for clients to update in the wild. We want to ensure that all
385-
;; clients DO respond to pings before enabling the server to close
386-
;; unresponsive connections.
387-
;;
388-
;; So we're rolling this new feature out in 2 steps:
389-
;; 1. Update clients to respond to pings (with pongs)
390-
;; 2. Update servers to regard lack of pong as broken conn
391-
;;
392-
;; The feature can be enabled early by manually providing a
393-
;; `ws-ping-timeout-ms` val in opts.
394-
;;
395-
ws-ping-timeout-ms nil #_(enc/ms :secs 5) ; TODO Enable default val
382+
ws-ping-timeout-ms (enc/ms :secs 5)
396383

397384
send-buf-ms-ajax 100
398385
send-buf-ms-ws 30

0 commit comments

Comments
 (0)