Skip to content

Commit a551f9e

Browse files
committed
[nop] Remove mention of vestigial handshake csrf
1 parent cab9648 commit a551f9e

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/taoensso/sente.cljc

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
3131
* Client-side events:
3232
[:chsk/ws-ping] ; ws-ping from server
33-
[:chsk/handshake [<?uid> nil[4] <?handshake-data> <first-handshake?>]]
33+
[:chsk/handshake [<?uid> nil <?handshake-data> <first-handshake?>]]
3434
[:chsk/state [<old-state-map> <new-state-map> <open-change?>]]
3535
[:chsk/recv <ev-as-pushed-from-server>] ; Server>user push
3636
@@ -75,10 +75,7 @@
7575
* Single HTTP req+session persists over entire chsk session but cannot
7676
modify sessions! Use standard a/sync HTTP Ring req/resp for logins, etc.
7777
* Easy to wrap standard HTTP Ring resps for transport over chsks. Prefer
78-
this approach to modifying handlers (better portability).
79-
80-
[4] Used to be a csrf-token. Was removed in v1.14 for security reasons.
81-
A `nil` remains for limited backwards-compatibility with pre-v1.14 clients."
78+
this approach to modifying handlers (better portability)."
8279

8380
{:author "Peter Taoussanis (@ptaoussanis)"}
8481
(:require
@@ -1156,12 +1153,7 @@
11561153

11571154
handshake-ev
11581155
[:chsk/handshake
1159-
[?uid nil ?handshake-data first-handshake?]
1160-
1161-
#_ ; TODO In a future breaking release?
1162-
{:uid ?uid
1163-
:handshake-data ?handshake-data
1164-
:first-handshake? first-handshake?}]]
1156+
[?uid nil ?handshake-data first-handshake?]]]
11651157

11661158
(timbre/infof "Client received %s %s handshake from server: %s"
11671159
(if first-handshake? "first" "new")

0 commit comments

Comments
 (0)