[nop] Clean up workaround for #247

Author: ptaoussanis

src/taoensso/sente.cljc

@@ -1160,9 +1160,8 @@
 
 #?(:clj
    (defmacro ^:private elide-require
-     "Experimental. The presence of `js/require` calls can cause issues with
-    React Native, even if they never execute. Currently no other known
-    workarounds. Ref. https://github.com/ptaoussanis/sente/issues/247."
+     "`js/require` calls can cause issues with React Native static analysis even
+     if they never execute, Ref. <https://github.com/ptaoussanis/sente/issues/247>."
      [& body]
      (when-not (enc/get-env {:as :bool} :sente-elide-js-require)
        `(do ~@body))))
@@ -1174,23 +1173,14 @@
        1. Add the lein-npm[2] plugin to your `project.clj`,
        2. Add: `:npm {:dependencies [[websocket \"1.0.23\"]]}`
 
-     [1] Ref. https://www.npmjs.com/package/websocket
-     [2] Ref. https://github.com/RyanMcG/lein-npm"
+     [1] Ref. <https://www.npmjs.com/package/websocket>
+     [2] Ref. <https://github.com/RyanMcG/lein-npm>"
 
-     ;; This `let` silliness intended to work around React Native's
-     ;; static analysis tool, to prevent it from detecting a
-     ;; missing package.
-     ;;
-     ;; Ref. https://github.com/ptaoussanis/sente/issues/247#issuecomment-555219121
-     ;;
      (let [make-package-name (fn [prefix] (str prefix "socket"))
-           require-fn
-           (if (exists? js/require)
-             js/require
-             (constantly :no-op))]
+           require-fn (if (exists? js/require) js/require (constantly :no-op))]
 
-       (delay ; Eager eval causes issues with React Native, Ref. #247,
-         (elide-require ; TODO is this now safe to remove?
+       (delay           ; For React Native, Ref. #247
+         (elide-require ; For React Native, Ref. #247
            (when (and node-target? (exists? js/require))
              (try
                (require-fn (make-package-name "web"))