Clj-kondo warning in log! call with :let

[Kaspazza]

I saw in RC-5 there was added clj-kondo mangment of many bindings, but still log! with :let binding is showing Unresolved symbol error.

[ptaoussanis]

Hi Mateusz, thanks for pinging!

I'm not familiar with clj-kondo, so can't really advise on this. Would be open to a PR to add/adjust hooks - if anyone more familiar felt like taking a look at that.

Note that I suspect all signal creators would be likewise affected.

[marksto]

Hi Peter! The with-signal and with-signals seem to have been missed in the previous clj-kondo issues-related PR. These are easy to fix by adding them into the declare block.

[ptaoussanis]

@marksto Thanks Mark! Just fixed on master 👍

[ozangulle]

I also have the same problem. I solved it locally by creating the following hook which is a modified version of an example in the clj-kondo documentation.

(ns hooks.telemere
  (:require [clj-kondo.hooks-api :as api]))

(defn extract-let-bindings [node]
  (when (api/map-node? node)
    (first (filter (fn [[key _]] (= :let (api/sexpr key))) (partition 2 (:children node))))))

(defn log! [{:keys [:node]}]
  (let [[config & body] (rest (:children node))
        binding-vector (extract-let-bindings config)]
    (if (nil? binding-vector)
      {:node node}
      (let [new-node (api/list-node
                      (list*
                       (api/token-node 'let)
                       (second binding-vector)
                       config
                       body))]
        {:node new-node}))))

and then adding the following to the local conf.edn

{:hooks {:analyze-call {taoensso.telemere/log! hooks.telemere/log!}}}

It's a bit crude but it works. I've never written a Clojure library myself so I don't know how to make telemere bring its own hooks.