GraphQL App returns 400

[sebastiandev]

GraphQL Apps should always return 200, even when there are errors. That is because a resolver might have failed but others might have been completed successfully so there will be data in the response. The 400 is reserved for graphql parsing errors.

This line here is causing tartiflette-asgi to return 400 if errors is populated. Removing it should bring the expected behavior.

Is there any reason why this convention is not followed?

[florimondmanca]

Hey,

Not really, I think! You seem to be more familiar with the details of the GraphQL protocol than I was at the time, so if there are changes you think are worth considering I'd be glad to review any pull request towards that. 😊

[sebastiandev]

Gotcha, here it is