-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform-specific note for Windows (Webview2 redistribution) #1268
Comments
Actually it requires a code change, because you have to pass the distribution path to the CreateCoreWebView2EnvironmentWithOptions call; it doesn't work if you just place the files alongside the executable. |
That's not true, what makes you think that? The need for the .dll is correct though, wry's docs are still from the time where we only supported the msvc toolchain. |
The error happens if you add wry on a x86_64-pc-windows-gnu target. |
Yes, the dll error/requirement is expected and really just how it works. What i mean is that this has no effect on whether you can use webview2 in evergreen mode or the fixed version and i'd like to know if we said something different somewhere (so we can update it). |
I just think this is important in the platform notes of the readme, or notes on cross-compilation. I didn't see any installation steps in the readme (github homepage) and I'm not a Windows specific developer so I know nothing about nuget or msvc and my expectation is that I don't have to do further research to make it work and avoid errors. A reference to the Microsoft docs would be helpful but it would be better if developers can just copy paste an install command to avoid many people wasting time on figuring out the same issue. |
Fwiw I reached this issue after running into the described error :) |
maybe related actions/runner-images#9538 |
With the x86_64-pc-windows-gnu target (cross-compilation) you automatically opt for the fixed version redistribution of Webview2. That's worthy of documentation.
The executable will give an error about WebView2Loader.dll because the wry documentation does not mention (yet) that you have to get the redistribution from here:
https://developer.microsoft.com/en-us/microsoft-edge/webview2?form=MA13LH#download
And choose a fixed version.
Details: https://learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution
The text was updated successfully, but these errors were encountered: