smarter exception handling, also some code cleanup

Author: tcprescott

README.md

@@ -104,4 +104,14 @@ rules:
     destinations:
       - name: default
         path: "/SuperMetroid/Rando"
-```
+```
+
+## Troubleshooting
+
+Problem: RomLoader hangs without any input
+Solutions:
+1. try restaring usb2snes.exe
+2. power off and back on your sd2snes
+3. load a non-special chip/MSU1 ROM through the sd2snes menu
+
+Basically RomLoader is having trouble interacting with the usb2snes.

src/py2snes/__init__.py

@@ -92,7 +92,7 @@ def Boot(self, romname):
         else:
             raise usb2snesException("Boot: not attached to usb2snes.  Try executing Attach first.")
 
-    def Menu(self, romname):
+    def Menu(self):
         if self.attached:
             cmd = {
                 'Opcode': 'Menu',

src/romloader.py

@@ -6,6 +6,17 @@
 import yaml
 
 from py2snes import usb2snes
+from py2snes import usb2snesException
+
+
+def show_exception_and_exit(exc_type, exc_value, tb):
+    import traceback
+    traceback.print_exception(exc_type, exc_value, tb)
+    input("Press key to exit.")
+    sys.exit(-1)
+
+sys.excepthook = show_exception_and_exit
+
 
 # load the configuration file (if it exists, otherwise use default config)
 scriptpath = os.path.dirname(sys.argv[0])
@@ -72,10 +83,7 @@ def main():
     else:
         path = config['default_destination']
         romname = filename
-    print("making {path} directory if it doesn't exist".format(
-        path=path
-    ))
-    conn.MakeDir('/romloader')
+        conn.MakeDir('/romloader')
     conn.List(path)
     print("copying rom to {fullpath}".format(
         fullpath=path + '/' + romname
@@ -87,7 +95,7 @@ def main():
     conn.Boot(path + '/' + romname)
     conn.close()
 
-    sleep(15)
+    sleep(5)
 
 
 def matchrule(name):

src/test.py

@@ -0,0 +1,5 @@
+import py2snes
+
+conn = py2snes.usb2snes()
+conn.Attach()
+print(conn.Info())