proposal: Ensure action fails when sender fails

[nallwhy]

Description

In the current implementation, when the sender fails to execute send, the action is still considered a success. This can lead to issues where critical failures go unnoticed because the system doesn’t propagate or handle the error effectively.

For example:
• A user requests a password reset.
• The system attempts to send a password reset email.
• If send fails, the action completes successfully without any indication of failure.

e.g.

ash_authentication/lib/ash_authentication/strategies/magic_link/request.ex

Line 37 in abe1a75

sender.send(to_string(identity), token, Keyword.put(send_opts, :tenant, context.tenant))

This behavior can result in users not receiving important notifications, while the system falsely assumes the operation was successful.

Proposed Solution

Introduce an option to control whether the action’s success depends on the result of send. Specifically:
1. Default Behavior: Maintain the current behavior for backward compatibility.
2. New Option: Add a configuration option (e.g., ensure_sender_success) that forces the action to fail if send fails.

[zachdaniel]

Works for me 👍 PRs welcome! There are multiple senders that will need to be configurable in this way.

[nallwhy]

@zachdaniel How do you feel about making this a breaking change in v5, setting the default of option to true? I’ve seen similar planned changes in Ash as well.

[zachdaniel]

We can discuss it, but it would make sense to me.