fix: always load components with seeders for dependency detection #10044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecific files When using 'bit install --add-missing-deps', dependencies in environment-specific files (like .vue files) were not being detected because components were loaded without their environments (loadSeedersAsAspects: false). This caused a cascading cache issue: 1. Components loaded without env → cached everywhere (workspace, consumer, deps data, parsed files) 2. Env-specific detectors (Vue, etc.) not available → dependencies not detected 3. Later loads couldn't fix it due to multiple cache layers Solution: Always load components with loadSeedersAsAspects: true in getComponentsDirectory. This ensures env detectors are available from the first load, and all caches contain correct dependency data. Note: This changes the behavior for ALL component loading in getComponentsDirectory. Tests will validate if this causes any regressions.
Add e2e test that reproduces and validates the fix for an issue where dependencies in files with custom extensions aren't detected when the detector is inherited from a base env that's installed as a package. Test setup: - Creates a custom detector for .custom files - Creates base-env with the detector - Creates extended-env that inherits from base-env - Exports envs as packages to npm registry - Creates new workspace with component using extended-env - Verifies lodash import in .custom file is detected The test validates: 1. Bug exists: bit status shows missing lodash dependency 2. Fix works: bit install --add-missing-deps resolves the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
bit install --add-missing-depsdoesn't detect dependencies imported in environment-specific files like.vuefiles when the detector is inherited from a base env. This happens because of a cascading cache issue:loadSeedersAsAspects, so env detectors aren't available--add-missing-deps, the cached data is used insteadloadSeedersAsAspectsparameter, so there's no way to invalidate the bad cacheSolution
Always load components with
loadSeedersAsAspects: truein thegetComponentsDirectorymethod. This ensures env detectors are available from the first load, so all cached data contains correct dependency information.Testing
Added e2e test that:
.customfiles--add-missing-depsThe test validates this change doesn't cause regressions while fixing the Vue env issue.