fix(ui-server): eliminate duplicate /_hmr proxy to restore WebSocket HMR
#9804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luvkapur
changed the title
/_hmr proxy to restore WebSocket HMR/_hmr proxy to restore WebSocket HMR
GiladShoham
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the generic
/_hmrWebSocket proxy entry fromUIServer.getProxy().Previously,
/_hmr/<envId>matched two ProxyEntrys (catch-all & env-specific) → the same socket was proxied twice, sending a second 101 header → “Invalid frame header / ECONNRESET” in the browser and broken HMRWith this fix,
Each HMR request matches exactly one proxy entry. The connection upgrades once; HMR frames flow without errors.