Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for the code herein #7

Open
Cryptophobia opened this issue Mar 13, 2018 · 6 comments
Open

Write unit tests for the code herein #7

Cryptophobia opened this issue Mar 13, 2018 · 6 comments

Comments

@Cryptophobia
Copy link
Member

From @arschles on April 13, 2016 16:33

Important sections of this codebase are protected by sync.Mutexes or sync.RWMutexes, so special attention should be paid to writing concurrent tests (so that we can run go test -race)

Copied from original issue: deis/logger#57

@Cryptophobia
Copy link
Member Author

From @arschles on April 21, 2016 15:47

Punting to beta4

@Cryptophobia
Copy link
Member Author

From @arschles on May 9, 2016 19:58

I'm moving this to RC1. Also note that I haven't looked at the state of the code or amount of coverage in unit tests yet. I just noticed that there are not many...

@Cryptophobia
Copy link
Member Author

From @bacongobbler on May 19, 2016 18:44

reclassifying as tests rather than a bug

@Cryptophobia
Copy link
Member Author

From @bacongobbler on May 19, 2016 18:45

@jchauncey would you be willing to take a crack at this or shall we punt to post-2.0?

@Cryptophobia
Copy link
Member Author

From @jchauncey on May 19, 2016 19:25

i have tests in stdout-metrics that does a lot of what we want to test in logger i just need time to port them. but yeah we should just wait

@Cryptophobia
Copy link
Member Author

From @Joshua-Anderson on September 9, 2016 20:27

@jchauncey Were said unit tests ever written? It looks like the logger had 70% coverage, though with recent refactors has fallen to 40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant