From fefe9a28c687b6baaca1e40b70f0a15584f4ae47 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 08:50:52 +0200 Subject: [PATCH 01/10] run lint on 16 --- .github/workflows/pr.yaml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 388e8e65..68c2c9cb 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -10,14 +10,17 @@ defaults: jobs: lint: - container: - image: node:9 - credentials: - username: ${{ secrets.DOCKER_HUB_USERNAME }} - password: ${{ secrets.DOCKER_HUB_PASSWORD }} runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - name: lint + - name: Check out code + uses: actions/checkout@v3 + with: + node-version: 16 + cache: 'npm' + - name: Install Node + uses: actions/setup-node@v3 + with: + node-version: 16 + cache: 'npm' run: | npm install && npm run build && npm run lint From 669dad26f5731f62f8cb8f0eec2d8b9205bb5ff4 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 08:59:00 +0200 Subject: [PATCH 02/10] Trigger CI From af1c8da26e2ca5d377c027e2ca9208a58d7a4714 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:03:11 +0200 Subject: [PATCH 03/10] [CON-X] | step cannot have uses and run together --- .github/workflows/pr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 68c2c9cb..9c3ecc5b 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -22,5 +22,6 @@ jobs: with: node-version: 16 cache: 'npm' + - name: Run Lint run: | npm install && npm run build && npm run lint From 219b39ddeccf0a0fa210c513b043b817e6be0091 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:10:25 +0200 Subject: [PATCH 04/10] downgrade node to 14 --- .github/workflows/pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 9c3ecc5b..222dab63 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -15,12 +15,12 @@ jobs: - name: Check out code uses: actions/checkout@v3 with: - node-version: 16 + node-version: 14 cache: 'npm' - name: Install Node uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 14 cache: 'npm' - name: Run Lint run: | From a4b08a5b8ace4521835de2fbf1935a2ee1ec1628 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:14:12 +0200 Subject: [PATCH 05/10] downgrade to node version 12 --- .github/workflows/pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 222dab63..3198610e 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -15,12 +15,12 @@ jobs: - name: Check out code uses: actions/checkout@v3 with: - node-version: 14 + node-version: 12 cache: 'npm' - name: Install Node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 12 cache: 'npm' - name: Run Lint run: | From f1799e27a44ddddffb3b82d959e70c587fa782f5 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:20:09 +0200 Subject: [PATCH 06/10] change to node 10 --- .github/workflows/pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 3198610e..34d89f9d 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -15,12 +15,12 @@ jobs: - name: Check out code uses: actions/checkout@v3 with: - node-version: 12 + node-version: 10 cache: 'npm' - name: Install Node uses: actions/setup-node@v3 with: - node-version: 12 + node-version: 10 cache: 'npm' - name: Run Lint run: | From 7dd0ae16ed50f6d352b790830659a267cf64ec5d Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:24:31 +0200 Subject: [PATCH 07/10] try node v9 --- .github/workflows/pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 34d89f9d..dab2ebd5 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -15,12 +15,12 @@ jobs: - name: Check out code uses: actions/checkout@v3 with: - node-version: 10 + node-version: 9 cache: 'npm' - name: Install Node uses: actions/setup-node@v3 with: - node-version: 10 + node-version: 9 cache: 'npm' - name: Run Lint run: | From 5f207646eac1b3a29f423bfd759760b552b920e0 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:31:11 +0200 Subject: [PATCH 08/10] try setting the previously default value of actions checkout --- .github/workflows/pr.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index dab2ebd5..15f40837 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -10,17 +10,17 @@ defaults: jobs: lint: + container: + image: node:9 + credentials: + username: ${{ secrets.DOCKER_HUB_USERNAME }} + password: ${{ secrets.DOCKER_HUB_PASSWORD }} runs-on: ubuntu-latest steps: - name: Check out code uses: actions/checkout@v3 with: - node-version: 9 - cache: 'npm' - - name: Install Node - uses: actions/setup-node@v3 - with: - node-version: 9 + node-version: 16 cache: 'npm' - name: Run Lint run: | From eda29bcf6bbbb09964c63789c942f7e23cc7feb8 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:37:26 +0200 Subject: [PATCH 09/10] run un node 12 image --- .github/workflows/pr.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 15f40837..a1827f81 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -11,7 +11,7 @@ defaults: jobs: lint: container: - image: node:9 + image: node:12 credentials: username: ${{ secrets.DOCKER_HUB_USERNAME }} password: ${{ secrets.DOCKER_HUB_PASSWORD }} @@ -19,9 +19,6 @@ jobs: steps: - name: Check out code uses: actions/checkout@v3 - with: - node-version: 16 - cache: 'npm' - name: Run Lint run: | npm install && npm run build && npm run lint From 64c9a6e87b1912db3d8ba06a079d5237869ce9c9 Mon Sep 17 00:00:00 2001 From: Enis Krasniqi Date: Fri, 5 Jul 2024 09:38:40 +0200 Subject: [PATCH 10/10] run on node 16 --- .github/workflows/pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index a1827f81..8c69683f 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -11,7 +11,7 @@ defaults: jobs: lint: container: - image: node:12 + image: node:16 credentials: username: ${{ secrets.DOCKER_HUB_USERNAME }} password: ${{ secrets.DOCKER_HUB_PASSWORD }}