Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few areas names overflow the box #8

Closed
1ted59 opened this issue Aug 7, 2019 · 5 comments
Closed

A few areas names overflow the box #8

1ted59 opened this issue Aug 7, 2019 · 5 comments
Assignees
Labels
menu-overflow The text in a menu option overflows to the next line or out of the box it's supposed to be in
Milestone

Comments

@1ted59
Copy link

1ted59 commented Aug 7, 2019

Description

A few areas not listed in #1 overflow the box. The few I've found so far are:
Desert Wastes
Desert Wastes Harbor
Funadel Wastes Harbor

Location of bug

(Saudi Arabia Area):
Desert Wastes
Desert Wastes Harbor

(North Europe Area):
Funadel Wastes Harbor

(Sahara Desert Area):
Seanile Tomb (Notably NOT Seanile Harbor)

Screenshot

Sorry can't post screenshot currently, but for all two characters overflow the box.

Additional Info

Will keep looking for more and update this issue if found

@1ted59 1ted59 added the menu-overflow The text in a menu option overflows to the next line or out of the box it's supposed to be in label Aug 7, 2019
@CakeLancelot
Copy link
Member

Thanks, I did have Funadel Wastes noted in #1 - but the others are new. Let me know if you find more. Should be able to take care of these for Beta 2.

@CakeLancelot CakeLancelot added this to the Beta 2 milestone Aug 7, 2019
@1ted59
Copy link
Author

1ted59 commented Aug 7, 2019

Ah sorry, I wasn't sure whether the Harbor section was accounted for in Funadel Wastes versus just the regular area. That's why I didn't list the regular area. So for all of those listed in #1 the harbor overflows as well?

@CakeLancelot
Copy link
Member

I wasn't sure whether the Harbor section was accounted for in Funadel Wastes versus just the regular area. That's why I didn't list the regular area. So for all of those listed in #1 the harbor overflows as well?

I assume so - I will check and specify this in the future.

@1ted59
Copy link
Author

1ted59 commented Aug 8, 2019

Just found an area where the harbor did not overflow but the inner area did (Senile Tomb).
I think the best way to deal with this is just to list every area and subarea, since they aren't both necessarily going to overflow at the same time.

@ultramario1998 ultramario1998 self-assigned this Aug 14, 2019
@ultramario1998
Copy link

Fixed.

Changed 'Funadel Wastes Harbor' / 'Funadel Wastes' to 'Funadel Isle' (in keeping with overworld names) (This won't work for Desert Wastes, mostly because it's not an isle.)

Shortened 'Desert Wastes Harbor' to 'Desert Wastes Hbr.'.

Expanded in-map names + nameplate pane size for Desert Wastes, Seanile Tomb, and Funadel Isle - they should all show up properly in the next build.

Closing issue for now. If OP comes across any more issues of this type, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menu-overflow The text in a menu option overflows to the next line or out of the box it's supposed to be in
Projects
None yet
Development

No branches or pull requests

3 participants