Remove getPersistentId, since it is incorrect (#23)

Author: junglebarry

Diff for: src/Talis/Persona/Client/Login.php

@@ -120,33 +120,6 @@ public function validateAuth()
         return $this->isLoggedIn();
     }
 
-    /**
-     * Get users persistent ID - it finds a persistent ID that matches the login provider
-     * @return boolean|string pid else boolean false
-     */
-    public function getPersistentId()
-    {
-        if (!isset($_SESSION[self::LOGIN_PREFIX . ':loginProvider'])) {
-            return false;
-        }
-
-        if (
-            isset($_SESSION[self::LOGIN_PREFIX . ':loginSSO']['gupid'])
-            && !empty($_SESSION[self::LOGIN_PREFIX . ':loginSSO']['gupid'])
-        ) {
-            // Loop through all gupids and match against the login provider - it should be
-            // the prefix of the persona profile
-            foreach ($_SESSION[self::LOGIN_PREFIX . ':loginSSO']['gupid'] as $gupid) {
-                $loginProvider = $_SESSION[self::LOGIN_PREFIX . ':loginProvider'];
-                if (strpos($gupid, $loginProvider) === 0) {
-                    return str_replace("$loginProvider:", '', $gupid);
-                }
-            }
-        }
-
-        return false;
-    }
-
     /**
      * Get redirect URL value
      * @return string|boolean redirect url else boolean false

Diff for: test/unit/Persona/LoginTest.php

@@ -405,103 +405,10 @@ public function testValidateAuthAfterRequireAuth()
 
         $this->assertTrue($mockClient->validateAuth());
 
-        $this->assertEquals('123', $mockClient->getPersistentId());
         $this->assertEquals(['919191'], $mockClient->getScopes());
         $this->assertEquals('http://example.com/wherever', $mockClient->getRedirectUrl());
     }
 
-    // getPersistentId tests
-    public function testGetPersistentIdNoSession()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $this->assertFalse($personaClient->getPersistentId());
-    }
-
-    public function testGetPersistentIdNoGupidInSession()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $_SESSION[Login::LOGIN_PREFIX . ':loginSSO'] = [];
-        $this->assertFalse($personaClient->getPersistentId());
-    }
-
-    public function testGetPersistentIdNoLoginProviderInSession()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $_SESSION[Login::LOGIN_PREFIX . ':loginSSO'] = [];
-        $this->assertFalse($personaClient->getPersistentId());
-    }
-
-    public function testGetPersistentIdEmptyGupids()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $_SESSION[Login::LOGIN_PREFIX . ':loginProvider'] = 'trapdoor';
-        $_SESSION[Login::LOGIN_PREFIX . ':loginSSO'] = ['gupid' => []];
-
-        $this->assertFalse($personaClient->getPersistentId());
-    }
-
-    public function testGetPersistentIdNoMatchingGupid()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $_SESSION[Login::LOGIN_PREFIX . ':loginProvider'] = 'trapdoor';
-        $_SESSION[Login::LOGIN_PREFIX . ':loginSSO'] = [
-            'gupid' => [
-                'google:123',
-                'twitter:456'
-            ]
-        ];
-        $this->assertFalse($personaClient->getPersistentId());
-    }
-
-    public function testGetPersistentIdFoundMatchingGupid()
-    {
-        $personaClient = new Login(
-            [
-                'userAgent' => 'unittest',
-                'persona_host' => 'localhost',
-                'cacheBackend' => $this->cacheBackend,
-            ]
-        );
-        $_SESSION[Login::LOGIN_PREFIX . ':loginProvider'] = 'trapdoor';
-        $_SESSION[Login::LOGIN_PREFIX . ':loginSSO'] = [
-            'gupid' => [
-                'google:123',
-                'trapdoor:456'
-            ]
-        ];
-        $this->assertEquals('456', $personaClient->getPersistentId());
-    }
-
     // getRedirectUrl tests
     public function testGetRedirectUrlNoSession()
     {