-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Points/Labels: Filter when out of range #264
Comments
Looking at Rule as an example and plans to mirror this in Points, I wonder if this is going to be necessary for other primitives and/or markup items? Point ? Could Spline use range filtering and then not need clipping at all when brushing? Is there a use case where Spline overflowing axis? Do other chart types have, or could have, a use case for zooming being a near equivilent to brushing and also benefit from this? I don't have enough familiarity with other components beyond linecharts. If this is more widespread applicable, maybe a internal wrapping utility |
Hmm.. few quick thoughts:
I need to put more thought into each of these, but there is definitely room for improvement. |
As I think about it you can't range filter things like spline as removing data out of axis range will change the appearance of the chart within the range view. That's why clip exists. Is there room for an opinionated z-index on axis, legend, etc above things like Spline? I'm just trying to think of a way to remove clipping all together? |
The order you render components indicates what is drawn on top (last wins), and you can also remove So you could only wrap |
Similar to the work done for Rule, we should filter any points which are outside of the Chart's x/y range, which is useful when brushing data and not needing to rely on a clip path.
See related discussion
The text was updated successfully, but these errors were encountered: