Assorted uplifts #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned9
changed the title
natelee-tw
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Wondering should we specify in the README that the entry path is /run_analysis.py? I think sometimes candidates could be searching for main.py
| ##### YOUR CODE GOES HERE ##### | ||
| pyplot.savefig(Path(__file__).parents[1].joinpath(*["plots", "left_right_parties.png"])) | ||
| pyplot.title("Lefty/righty parties") | ||
| plt.title("Lefty/righty parties") |
There was a problem hiding this comment.
I think since we have commented out the code for dim_reduced_data charts above, should we also comment out these codes?
| @@ -1,43 +1,46 @@ | |||
| from pathlib import Path | |||
|
|
|||
| from matplotlib import pyplot | |||
| import matplotlib.pyplot as plt | |||
|
|
|||
| from political_party_analysis.loader import DataLoader | |||
There was a problem hiding this comment.
As run_analysis.py is now in root directory, rather than src/, the import should be from src.political_party_analysis.loader import DataLoader
There was a problem hiding this comment.
Since run_analysis.py is in repo root now, maybe we could remove "political_party_analysis" folder and simply move the files to src/? (i.e. import from src.loader)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A range of uplifts to the codebase:
pyproject.toml & poetry.lock
[project]rather than[tool.poetry]*version specifiers for dependencies with locked major versionsother changes:
test_dimensionality_reducertesttest_dimensionality_reducertest as skipped initially, so that tests can go green after completing first exerciserun_analysis.pyto the top level directory, which is a less surprising location for workflow runner, and will ensure that the package has been installed correctly (and not succeeding just because it's in the same directory as thepolitical_party_analysismodule).gitignoreloader.py,visualization.py, anddim_reducer.pyrun_analysis.pyandloader.py