Skip to content

Commit 9ae04e1

Browse files
Revert "Add edit feature for tasbih entries with counter protection"
This reverts commit f79e90a.
1 parent f79e90a commit 9ae04e1

File tree

2 files changed

+3
-57
lines changed

2 files changed

+3
-57
lines changed

core_functions/tasbih/controller.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,5 @@ def delete_all_entries(self):
145145
logger.info("All tasbih entries deleted. Reinitializing default entries.")
146146
self._initialize_default_entries()
147147
except Exception as e:
148-
logger.error(f"Error deleting all tasbih entries: {e}", exc_info=True)
149-
150-
151-
def update_entry_name(self, entry_id: int, new_name: str):
152-
"""update tasbih entrie."""
153-
logger.debug(f"Updating name of tasbih entry ID {entry_id} to '{new_name}'")
154-
entry = self.get_entry(entry_id)
155-
if entry:
156-
old_name = entry.name
157-
entry.name = new_name
158-
self.update_entry(entry)
159-
self.entrieUpdated.emit(entry)
160-
logger.info(f"Updated tasbih name from '{old_name}' to '{new_name}' (ID: {entry_id})")
148+
logger.error(f"Error deleting all tasbih entries: {e}", exc_info=True)
149+

ui/dialogs/tasbih_dialog.py

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ def __init__(self, parent) -> None:
3838
self.addButton.setToolTip("إضافة تسبيح")
3939
self.addButton.setAccessibleName("إضافة تسبيح")
4040

41-
self.editButton = QPushButton()
42-
self.editButton.setIcon(qta.icon("fa.edit"))
43-
self.editButton.setToolTip("تعديل التسبيح")
44-
self.editButton.setAccessibleName("تعديل التسبيح")
45-
self.editButton.setEnabled(False)
46-
4741
self.delete_button = QPushButton()
4842
self.delete_button.setIcon(qta.icon("fa.trash"))
4943
self.delete_button.setToolTip("حذف تسبيح")
@@ -94,7 +88,6 @@ def __init__(self, parent) -> None:
9488
gridLayout = QGridLayout()
9589
gridLayout.addWidget(self.openButton, 0, 0)
9690
gridLayout.addWidget(self.addButton, 0, 1)
97-
gridLayout.addWidget(self.editButton, 0, 3)
9891
gridLayout.addWidget(self.delete_button, 0, 2)
9992
gridLayout.addWidget(self.incrementButton, 1, 0)
10093
gridLayout.addWidget(self.decrementButton, 1, 1)
@@ -109,7 +102,6 @@ def __init__(self, parent) -> None:
109102
# Connect UI button clicks to slots.
110103
self.openButton.clicked.connect(self.open_tasbih_entry_dialog)
111104
self.addButton.clicked.connect(self.handle_add_entry)
112-
self.editButton.clicked.connect(self.handle_edit_entry)
113105
self.delete_button.clicked.connect(self.handle_delete_entry)
114106
self.incrementButton.clicked.connect(self.handle_increment)
115107
self.decrementButton.clicked.connect(self.handle_decrement)
@@ -162,20 +154,6 @@ def open_tasbih_entry_dialog(self):
162154
UniversalSpeech.say(F"مرحبا بك في المِسْبَحَة، التسبيح: {tasbih_entry.name}، العدد: {tasbih_entry.counter}. استخدم المفاتيح التالية لزيادة العداد: Space, Enter, +,أو C. لإنقاص العداد استخدم: D, Ctrl+Space, -, أو Backspace. لإعادة تعيين العداد استخدم: Ctrl+R. للمعلومات استخدم: V للعدد، T للذِكر، I للكل.")
163155
dialog.exec()
164156

165-
def update_edit_button_state(self):
166-
selected_item = self.listWidget.currentItem()
167-
if not selected_item:
168-
self.editButton.setEnabled(False)
169-
return
170-
171-
entry_id = selected_item.data(Qt.ItemDataRole.UserRole)
172-
entry = self.controller.get_entry(entry_id)
173-
if entry and entry.counter > 0:
174-
self.editButton.setEnabled(False)
175-
else:
176-
self.editButton.setEnabled(True)
177-
178-
179157
def OnItemSelectionChanged(self):
180158
status = bool(self.listWidget.selectedItems())
181159
self.openButton.setEnabled(status)
@@ -184,10 +162,7 @@ def OnItemSelectionChanged(self):
184162
self.resetButton.setEnabled(status)
185163
self.delete_button.setEnabled(status)
186164
self.resetAllButton.setEnabled(status)
187-
self.editButton.setEnabled(status)
188165
self.deleteAllButton.setEnabled(status)
189-
self.update_edit_button_state()
190-
191166
logger.debug(f"List item selection status: {status}. Buttons enabled: {status}.")
192167

193168
def populate_list(self):
@@ -208,21 +183,6 @@ def add_list_item(self, entry):
208183
self.listWidget.addItem(item)
209184
logger.debug(f"Added Tasbih entry to list: {entry.name} (ID: {entry.id}, Count: {entry.counter})")
210185

211-
def handle_edit_entry(self):
212-
selected_item = self.listWidget.currentItem()
213-
if not selected_item:
214-
return
215-
entry_id = selected_item.data(Qt.ItemDataRole.UserRole)
216-
old_entry = self.controller.get_entry(entry_id)
217-
218-
new_name, ok = QInputDialog.getText(self, "تعديل التسبيح", "أدخل الاسم الجديد:", text=old_entry.name)
219-
if ok and new_name.strip():
220-
self.controller.update_entry_name(entry_id, new_name.strip())
221-
updated_entry = self.controller.get_entry(entry_id)
222-
item_text = f"{updated_entry.name} | {updated_entry.counter}"
223-
selected_item.setText(item_text)
224-
UniversalSpeech.say(f"تم تعديل التسبيح إلى: {updated_entry.name}")
225-
226186
def handle_add_entry(self):
227187
"""Called when the Add button is clicked.
228188
@@ -275,7 +235,6 @@ def handle_increment(self):
275235
entry_id = selected_item.data(Qt.ItemDataRole.UserRole)
276236
logger.debug(f"Incrementing counter for Tasbih entry ID: {entry_id}")
277237
self.controller.increment_entry_counter(entry_id)
278-
self.update_edit_button_state()
279238

280239
def handle_decrement(self):
281240
"""Decrement the counter for the selected entry."""
@@ -284,16 +243,14 @@ def handle_decrement(self):
284243
entry_id = selected_item.data(Qt.ItemDataRole.UserRole)
285244
logger.debug(f"Decrementing counter for Tasbih entry ID: {entry_id}")
286245
self.controller.decrement_entry_counter(entry_id)
287-
self.update_edit_button_state()
288-
246+
289247
def handle_reset(self):
290248
"""Reset the counter for the selected entry."""
291249
logger.debug("Reset button has been clicked")
292250
selected_item = self.listWidget.currentItem()
293251
entry_id = selected_item.data(Qt.ItemDataRole.UserRole)
294252
logger.warning(f"Resetting counter for Tasbih entry ID: {entry_id}")
295253
self.controller.reset_entry_counter(entry_id)
296-
self.update_edit_button_state()
297254

298255
def handle_delete_entry(self):
299256
"""Delete the selected entry."""

0 commit comments

Comments
 (0)