Linked add_to_startup and remove_from_startup methods with their option in SettingsDialog.

Author: MahmoudAtef999

ui/dialogs/settings_dialog.py

@@ -20,9 +20,10 @@
 from PyQt6.QtGui import QKeySequence
 from PyQt6.QtCore import Qt
 from core_functions.Reciters import RecitersManager
-from utils.const import data_folder
+from utils.const import data_folder, program_english_name
 from utils.settings import SettingsManager
 from utils.audio_player import AthkarPlayer, AyahPlayer, SoundEffectPlayer
+from utils.Startup import StartupManager
 
 
 class SettingsDialog(QDialog):
@@ -194,20 +195,23 @@ def updateBackgroundCheckboxState(self):
             # If 'start_on_system_start_checkbox' is checked, automatically check 'run_in_background_checkbox'
             self.run_in_background_checkbox.setChecked(True)
 
-
     def updateStartCheckboxState(self):
 
         # Check if 'run_in_background_checkbox' is unchecked, then uncheck 'start_on_system_start_checkbox'
         if not self.run_in_background_checkbox.isChecked():
             self.start_on_system_start_checkbox.setChecked(False)
 
+    def save_settings(self):
 
+        if SettingsManager.current_settings["general"]["auto_start_enabled"] != self.start_on_system_start_checkbox.isChecked():
+            if self.start_on_system_start_checkbox.isChecked():
+                StartupManager.add_to_startup(program_english_name)
+            else:
+                StartupManager.remove_from_startup(program_english_name)
 
-
-    def save_settings(self):
         general_settings = {
             "run_in_background_enabled": self.run_in_background_checkbox.isChecked(),
-            "start_on_system_starts_enabled": self.start_on_system_start_checkbox.isChecked(),
+            "auto_start_enabled": self.start_on_system_start_checkbox.isChecked(),
             "auto_save_position_enabled": self.auto_save_position_checkbox.isChecked(),
             "check_update_enabled": self.update_checkbox.isChecked(),
             "logging_enabled": self.log_checkbox.isChecked()
@@ -264,7 +268,7 @@ def set_current_settings(self):
         self.athkar_volume.setValue(current_settings["audio"]["athkar_volume_level"])
         self.ayah_volume.setValue(current_settings["audio"]["ayah_volume_level"])
         self.run_in_background_checkbox.setChecked(current_settings["general"]["run_in_background_enabled"])
-        self.start_on_system_start_checkbox.setChecked(current_settings["general"]["start_on_system_starts_enabled"])
+        self.start_on_system_start_checkbox.setChecked(current_settings["general"]["auto_start_enabled"])
         self.auto_save_position_checkbox.setChecked(current_settings["general"]["auto_save_position_enabled"])
         self.update_checkbox.setChecked(current_settings["general"]["check_update_enabled"])
         self.log_checkbox.setChecked(current_settings["general"]["logging_enabled"])

utils/Startup.py

@@ -1,36 +1,52 @@
 import winreg as reg
 import os
+import sys
+from utils.logger import Logger
 
 class StartupManager:
     STARTUP_KEY = r"Software\Microsoft\Windows\CurrentVersion\Run"
+    app_path = f'"{os.path.abspath(sys.argv[0])}" --minimized'
+    Logger.info(app_path)
 
     @staticmethod
-    def add_to_startup(app_name, app_path):
+    def add_to_startup(app_name: str) -> None:
         """
         Adds the application to the Windows startup registry.
 
         :param app_name: Name of the application (Registry key name).
-        :param app_path: Full path to the executable with arguments if necessary.
         """
+        if not sys.argv[0].endswith(".exe"):
+            return
+
         try:
             with reg.OpenKey(reg.HKEY_CURRENT_USER, StartupManager.STARTUP_KEY, 0, reg.KEY_SET_VALUE) as registry_key:
-                reg.SetValueEx(registry_key, app_name, 0, reg.REG_SZ, app_path)
-                print(f"{app_name} added to startup successfully.")
+                reg.SetValueEx(registry_key, app_name, 0, reg.REG_SZ, StartupManager.app_path)
+                Logger.info(f"{app_name} added to startup successfully.")
         except WindowsError as e:
-            print(f"Failed to add {app_name} to startup: {e}")
+            Logger.error(f"Failed to add {app_name} to startup: {e}")
 
     @staticmethod
-    def remove_from_startup(app_name):
-        """
-        Removes the application from the Windows startup registry.
-
-        :param app_name: Name of the application (Registry key name).
-        """
+    def remove_from_startup(app_name: str) -> None:
+        """Removes the application from the Windows startup registry."""
         try:
             with reg.OpenKey(reg.HKEY_CURRENT_USER, StartupManager.STARTUP_KEY, 0, reg.KEY_SET_VALUE) as registry_key:
                 reg.DeleteValue(registry_key, app_name)
-                print(f"{app_name} removed from startup successfully.")
+                Logger.info(f"{app_name} removed from startup successfully.")
+        except FileNotFoundError:
+            Logger.error(f"{app_name} not found in startup.")
+        except WindowsError as e:
+            Logger.error(f"Failed to remove {app_name} from startup: {e}")
+
+    @staticmethod
+    def is_in_startup(app_name: str) -> bool:
+        """Checks if the application is registered in the Windows startup registry."""
+        try:
+            with reg.OpenKey(reg.HKEY_CURRENT_USER, StartupManager.STARTUP_KEY, 0, reg.KEY_READ) as registry_key:
+                reg.QueryValueEx(registry_key, app_name)
+                return True
         except FileNotFoundError:
-            print(f"{app_name} not found in startup.")
+            return False
         except WindowsError as e:
-            print(f"Failed to remove {app_name} from startup: {e}")
+            Logger.error(f"Failed to check startup status: {e}")
+            return False
+        

utils/const.py

@@ -24,6 +24,7 @@
 
 # program information
 program_name = "البيان"
+program_english_name = "Albayan"
 program_version = "1.3.0"
 program_icon = "icon.webp"
 tray_icon: Optional[QSystemTrayIcon] = None

utils/settings.py

@@ -11,7 +11,7 @@ class SettingsManager:
         "general": {
             "language": "Arabic",
             "run_in_background_enabled": False,
-            "start_on_system_starts_enabled": False,
+            "auto_start_enabled": True,
             "auto_save_position_enabled": False,
             "check_update_enabled": True,
             "logging_enabled": False