You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GetWorkerStopChannel() should indicate that a worker has begun shutting down
Actual Behavior
GetWorkerStopChannel() for local activities now indicates when the local activity specific stop channel has closed. This is due to #1875.
The solution should be to also keep the worker stop channel in the Local Activity poller and have GetWorkerStopChannel() return that, while also ensuring shutdown behaves properly and the LA specific stop channel is closed at the right time.
Once this is fixed, see TODO comment linking this issue in integration tests and have Local Activity wait on that channel closure, instead of a manual time wait, to avoid potential race conditions
Steps to Reproduce the Problem
Specifications
Version:
Platform:
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Expected Behavior
GetWorkerStopChannel()
should indicate that a worker has begun shutting downActual Behavior
GetWorkerStopChannel()
for local activities now indicates when the local activity specific stop channel has closed. This is due to #1875.The solution should be to also keep the worker stop channel in the Local Activity poller and have GetWorkerStopChannel() return that, while also ensuring shutdown behaves properly and the LA specific stop channel is closed at the right time.
Once this is fixed, see TODO comment linking this issue in integration tests and have Local Activity wait on that channel closure, instead of a manual time wait, to avoid potential race conditions
Steps to Reproduce the Problem
Specifications
The text was updated successfully, but these errors were encountered: