Skip to content

GetWorkerStopChannel no longer indicates worker shutdown for Local Activities #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuandrew opened this issue May 30, 2025 · 0 comments · May be fixed by #1965
Open

GetWorkerStopChannel no longer indicates worker shutdown for Local Activities #1963

yuandrew opened this issue May 30, 2025 · 0 comments · May be fixed by #1965
Labels
bug Something isn't working

Comments

@yuandrew
Copy link
Contributor

yuandrew commented May 30, 2025

Expected Behavior

GetWorkerStopChannel() should indicate that a worker has begun shutting down

Actual Behavior

GetWorkerStopChannel() for local activities now indicates when the local activity specific stop channel has closed. This is due to #1875.

The solution should be to also keep the worker stop channel in the Local Activity poller and have GetWorkerStopChannel() return that, while also ensuring shutdown behaves properly and the LA specific stop channel is closed at the right time.

Once this is fixed, see TODO comment linking this issue in integration tests and have Local Activity wait on that channel closure, instead of a manual time wait, to avoid potential race conditions

Steps to Reproduce the Problem

Specifications

  • Version:
  • Platform:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant