Skip to content

Fix GetWorkerStopChannel() for Local Activities #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix GetWorkerStopChannel() for Local Activities #1965

wants to merge 2 commits into from
+29 −15

Conversation

yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Jun 5, 2025 •
edited
Loading

What was changed

Plumb WorkerStopChannel through for Local Activities

Why?

Looks like this was never implemented to begin with

Checklist

  1. Closes GetWorkerStopChannel no longer indicates worker shutdown for Local Activities #1963

  2. How was this tested:

Changed a few tests to use this to avoid a race condition

  1. Any docs updates needed?

@yuandrew yuandrew requested a review from a team as a code owner June 5, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetWorkerStopChannel no longer indicates worker shutdown for Local Activities
1 participant
@yuandrew