feat: make `--verify` without specifying the verification url

[zerosnacks]

Component

Forge

Describe the feature you would like

Could be implemented by private forking alloy-chains or implementing a local workaround here

Additional context

No response

[zerosnacks]

cc @grandizzy for visibility

[grandizzy]

@zerosnacks I have a working branch that requires only export VERIFIER_URL=https://tempo:reverent-einstein-thirsty-edison@scout.tempo.xyz/api/ to verify and pretty straightforward but we should think how to upstream to foundry oss without breaking changes, should we proceed with it and worry about later?

diff --git a/crates/forge/src/cmd/create.rs b/crates/forge/src/cmd/create.rs
index 61c9d0dba..218f3a8cd 100644
--- a/crates/forge/src/cmd/create.rs
+++ b/crates/forge/src/cmd/create.rs
@@ -244,7 +244,7 @@ async fn verify_preflight_check(
             retry: self.retry,
             libraries: self.build.libraries.clone(),
             root: None,
-            verifier: self.verifier.clone(),
+            verifier: self.verifier.clone().normalized(),
             via_ir: self.build.via_ir,
             evm_version: self.build.compiler.evm_version,
             show_standard_json_input: self.show_standard_json_input,
@@ -433,7 +433,7 @@ async fn deploy<P: Provider<AnyNetwork>>(
             retry: self.retry,
             libraries: self.build.libraries.clone(),
             root: None,
-            verifier: self.verifier,
+            verifier: self.verifier.normalized(),
             via_ir: self.build.via_ir,
             evm_version: self.build.compiler.evm_version,
             show_standard_json_input: self.show_standard_json_input,
diff --git a/crates/script/src/verify.rs b/crates/script/src/verify.rs
index ceec637e6..1d87e7b38 100644
--- a/crates/script/src/verify.rs
+++ b/crates/script/src/verify.rs
@@ -32,7 +32,7 @@ pub async fn verify(self) -> Result<()> {
             &script_config.config,
             build_data.known_contracts,
             args.retry,
-            args.verifier,
+            args.verifier.normalized(),
         );
 
         for sequence in sequence.sequences_mut() {
@@ -158,7 +158,7 @@ pub fn get_verify_args(
                     retry: self.retry,
                     libraries: libraries.to_vec(),
                     root: None,
-                    verifier: self.verifier.clone(),
+                    verifier: self.verifier.clone().normalized(),
                     via_ir: self.via_ir,
                     evm_version: Some(evm_version),
                     show_standard_json_input: false,
diff --git a/crates/verify/src/verify.rs b/crates/verify/src/verify.rs
index f9ce32a41..6f2b2b0dc 100644
--- a/crates/verify/src/verify.rs
+++ b/crates/verify/src/verify.rs
@@ -49,6 +49,17 @@ pub struct VerifierArgs {
     pub verifier_url: Option<String>,
 }
 
+impl VerifierArgs {
+    pub fn normalized(mut self) -> Self {
+        if self.verifier == VerificationProviderType::Sourcify && self.verifier_url.is_some() {
+            self.verifier = VerificationProviderType::Custom;
+        }
+        self
+    }
+}
+

[grandizzy]

or we can just default to custom and export VERIFIER_URL=https://tempo:reverent-einstein-thirsty-edison@scout.tempo.xyz/api/ 🤷‍♂️

diff --git a/crates/verify/src/verify.rs b/crates/verify/src/verify.rs
index f9ce32a41..e012e3985 100644
--- a/crates/verify/src/verify.rs
+++ b/crates/verify/src/verify.rs
@@ -37,7 +37,7 @@ pub enum ContractLanguage {
 #[derive(Clone, Debug, Parser)]
 pub struct VerifierArgs {
     /// The contract verification provider to use.
-    #[arg(long, help_heading = "Verifier options", default_value = "sourcify", value_enum)]
+    #[arg(long, help_heading = "Verifier options", default_value = "custom", value_enum)]
     pub verifier: VerificationProviderType,
 
     /// The verifier API KEY, if using a custom provider.

[zerosnacks]

what was implemented in #60

requires using to export VERIFIER_URL=https://tempo:reverent-einstein-thirsty-edison@scout.tempo.xyz/api/ to allow user to pass --verify

what we would want as a follow up is that we get the verifier URL (presumably from a private fork of alloy-chains) so the user does not have to configure it themselves