-
-
Notifications
You must be signed in to change notification settings - Fork 255
On Linux, "audio device selector" toolbars is too small and dropdowns are cut off #435
Comments
The screenshot on the right is how it looks with wxWidgets 3.1.5 on a high DPI screen. I don't know if this affects lower resolution screens. I also do not know if the bug is in Tenacity or wxWidgets. |
Maybe a pop-up dialog would be a better solution than the drop down menu? |
Why is this even in the main window? |
Channel assignment should be on tcp, channel count on track creation, audio device / host in device settings imo. Also the strange decision to have field description on the two first lines of the channel count selector. |
Mockups or PRs would be great @akleja! I don't have the capacity to follow the design discussions in detail and work on the build system simultaneously but you seem to have good ideas. |
I do have a mockup in the works. So far it's limited to the main window, but I plan on extending it to include some rework of the settings. The tcp needs a lot of love as well. Regarding the toolbar in question, all those settings are present in the device settings in the prefs window. Removing it would not hurt in the least imo. But maybe replacing it with a small status toolbar that shows buffer size and samplerate and which acts as a shortcut to the device settings might be a good replacement. I'll see what I can come up with. Thank you! You're doing an amazing work on the build system. |
Good idea. |
Wait, are the audio buffer size and sample rate really so important to always be visible on screen in the main window? Maybe just the cog would be sufficient. |
No perhaps not, that might just be my personal preferences. Perhaps those could be shown in the corner of the status bar? |
I like both of these ideas. |
Cool, I'll look into it a bit more after the weekend. I'm leaning towards merging sliders and meters. It'll be a bigger challenge, and will take some time, but it's probably worth it in the end. |
I hope you don't mean overlapping the sliders and the meters like Traktor: |
Oh yeah no way. I agree that'd be utterly useless. |
That looks good, keep going! |
Nice. Could you open a draft pull request? |
Yeah I'll have to do a bit of cleanup first, but I'll open one when that's done. |
Another question. Do we really need the device menu in the "Extra" menu? Currently it's tied into the combo boxes in the device toolbar. I guess I could migrate the code into a more suitable place. It just seems a bit redundant with the device settings existing and all, but perhaps it serves a purpose? |
Where is the "Extra" menu that you are referring to? |
It has to be enabled in prefs/interface |
Yeah, that Extras > Device menu should be removed. It doesn't even do anything on my machine. Also the whole Extra menu should probably be broken up and moved to appropriate places. IMO "extras" and "advanced" modes are always cop-outs for actually making a good design. |
Yeah I agree. I'll remove the Extras > Device menu for now. The rest has to be sorted out later, but a lot of it seems superfluous to me. |
I just tried using a screen reader on linux. The screen reader support isn't that great. I'm thinking it might be a good idea to add the new i/o menus to the Extras menu anyway for now. Maybe later all the stuff in the extras menu can be moved out into the regular menus, but not having the device options in the menus is probably a bad idea for visually impaired users who would have a hard time using the toolbars. And at least with Orca, menus are a lot smoother to navigate than the prefs window. |
Describe the bug
On Linux, the "audio device selector" toolbar is too small and cuts off the left side of the combo boxes/dropdowns.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The toolbars are expanded, or the dropdowns are shrunken, so the audio device selector dropdowns don't have their left sides cut off.
As a workaround, you can drag the right side of the toolbar to expand it until the dropdowns are fully visible.
Screenshots
If applicable, add screenshots to help explain your problem.
https://twitter.com/TenacityAudio/status/1424146535386865668
Additional information (please complete the following information):
Additional context
Looking at the tweet linked above, apparently the issue also happens on GNOME. I think this issue happens on all Linux DEs where WxWidgets is backed by wxGTK and GTK 3, on both low and high DPI desktops, but I don't encounter it on Windows.
The text was updated successfully, but these errors were encountered: