Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto file sourcing #2228

Open
SkinnySackboy opened this issue Jul 5, 2024 · 7 comments
Open

Proto file sourcing #2228

SkinnySackboy opened this issue Jul 5, 2024 · 7 comments
Assignees

Comments

@SkinnySackboy
Copy link

Hi all,

I'm fairly new to TF Serving (I've been tasked with making calls to it). For some background here, we are interested in making TF Serving calls from .NET.

Usually we are used to easily sourcing the *.proto files, generating a client automatically within .NET, job done.

With TF Serving, we are having a hard time identifying where to get these files from. Aside from there being plenty of files (not an issue) they seem to be spread across multiple places. Furthermore, they seem to be mixed in folders containing code, and some of these files seem to reference *.proto files in entirely separate github repositories.

As such, it has become incredibly laborious for us to identify these proto files and organize them in such a way that we can automatically generate our clients. Furthermore, upon successive versions, backwards compatibility aside, it is rather painful to perform this process from scratch.

Am I doing something wrong? Is there a more effective place to get the *.proto files from that I'm not aware of?

Thanks in advance.

@quantike
Copy link

Curious if you've found any solutions here? I am tasked with a similar issue and cannot seem to get the *.proto files to correctly compile. There is seemingly an issue with all the error_codes.proto files. There is some transition happening that is moving those files around.

@SkinnySackboy
Copy link
Author

We have a solution but it's awful, what I still have no solution for is something official that just works out of the box.

@quantike
Copy link

Ouch. Hopefully there is an official tool eventually, or at least a link to something that is known to work

@SkinnySackboy
Copy link
Author

Agreed, it's remarkable that hardly anyone else seems to be complaining about this. It's literally the entire point of gRPC.

@janasangeetha janasangeetha self-assigned this Dec 16, 2024
@janasangeetha
Copy link

Hi @SkinnySackboy
Sorry for responding this issue late. Usually *.proto files are stored in tensorflow_serving/apis/*.proto.
Optionally you can use Buf’s managed mode to get all the *.proto files in one folder.
Please feel free to reach out to us if you need further information.
Thank you!

Copy link

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Dec 24, 2024
@SkinnySackboy
Copy link
Author

Thanks @janasangeetha I'll try this out as soon as I get the chance. Last time I did though, the proto files were referencing other files from all over the place, including other GitHub repos. The bit I'm not clear on is, assuming you can get them all into a single folder, how this would work as any paths within the files themselves would still need to be fixed.

@google-ml-butler google-ml-butler bot removed stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants