Use with to make it more simple

terenceponce · Nov 29, 2023 · c509804 · c509804
1 parent c1fed6c
commit c509804
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/lib/solutions/00013_roman_to_integer/roman_to_integer.ex b/lib/solutions/00013_roman_to_integer/roman_to_integer.ex
@@ -33,16 +33,12 @@ defmodule LeetCodePractice.Solutions.RomanToInteger do
       |> Enum.with_index()
 
     Enum.reduce(values, 0, fn {x, i}, acc ->
-      if i < length(values) - 1 do
-        next = Enum.at(values, i + 1) |> elem(0)
-
-        if x < next do
-          acc - x
-        else
-          acc + x
-        end
+      with true <- i < length(values) - 1,
+           next <- values |> Enum.at(i + 1) |> elem(0),
+           true <- x < next do
+        acc - x
       else
-        acc + x
+        _ -> acc + x
       end
     end)
   end