Skip to content

Commit 342c780

Browse files
feat: Sync with main
* Sync DA code with main DA * Prefix now required input by user
1 parent 47d4e24 commit 342c780

35 files changed

+231
-780
lines changed

.catalog-onboard-pipeline.yaml

+2-7
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,12 @@ apiVersion: v1
33
offerings:
44
- name: testing-deploy-arch-ibm-scc
55
kind: solution
6-
catalog_id: 7df1e4ca-d54c-4fd0-82ce-3d13247308cd
7-
offering_id: 9423f9bc-1290-4c71-a9ac-01898bfa7ccc
6+
catalog_id: f64499c8-eb50-4985-bf91-29f9e605a433
7+
offering_id: b773b1d4-69bb-48db-a657-2307015eb9c1
88
variations:
99
- name: instances
1010
mark_ready: true
1111
install_type: fullstack
1212
scc:
1313
instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37
1414
region: us-south
15-
- name: agents
16-
mark_ready: true
17-
install_type: extension
18-
pre_validation: "tests/scripts/pre-validation-deploy-slz-roks-and-scc-wp-instances.sh"
19-
post_validation: "tests/scripts/post-validation-destroy-slz-roks-and-scc-wp-instances.sh"

.releaserc

+3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
}],
1111
["@semantic-release/exec", {
1212
"successCmd": "echo \"SEMVER_VERSION=${nextRelease.version}\" >> $GITHUB_ENV"
13+
}],
14+
["@semantic-release/exec",{
15+
"publishCmd": "./ci/trigger-catalog-onboarding-pipeline.sh --version=v${nextRelease.version}"
1316
}]
1417
]
1518
}

README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@
1010
[![Renovate enabled](https://img.shields.io/badge/renovate-enabled-brightgreen.svg)](https://renovatebot.com/)
1111
[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
1212

13-
This repository contains the following infrastructure as code solutions:
13+
This repository contains the following infrastructure as code solution:
1414
- [Security and Compliance Center instances solution](./solutions/instances)
15-
- [Security and Compliance Center Workload Protection agents solution](./solutions/agents)
1615

17-
:exclamation: **Important:** These solutions are not intended to be called by other modules because they contain a provider configuration and are not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers)
16+
:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers)
1817

1918
<!-- Leave this section as is so that your module has a link to local development environment set up steps for contributors to follow -->
2019
## Contributing

cra-config.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ CRA_TARGETS:
88
TF_VAR_resource_group_name: "test"
99
TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
1010
TF_VAR_provider_visibility: "public"
11+
TF_VAR_prefix: "scc-cra"

ibm_catalog.json

+59-17
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"solution"
2323
],
2424
"short_description": "Creates and configures IBM Security and Compliance Center resources",
25-
"long_description": "Looking for the released version? Go [here](https://cloud.ibm.com/catalog/7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3/architecture/deploy-arch-ibm-scc-9423f9bc-1290-4c71-a9ac-01898bfa7ccc-global). Stay here if you want to try an experimental version with upcoming features. \n\nThis architecture supports creating and configuring IBM Security and Compliance Center resources.",
25+
"long_description": "Looking for the released version? Go [here](https://cloud.ibm.com/catalog/7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3/architecture/deploy-arch-ibm-scc-9423f9bc-1290-4c71-a9ac-01898bfa7ccc-global). Stay here if you want to try an experimental version with the [Optional and swappable components](https://cloud.ibm.com/docs/secure-enterprise?topic=secure-enterprise-choose-plan-process#optional-swappable) capability. \n\nThis architecture supports creating and configuring IBM Security and Compliance Center resources.",
2626
"offering_docs_url": "https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/blob/main/solutions/instances/README.md",
2727
"offering_icon_url": "https://raw.githubusercontent.com/terraform-ibm-modules/terraform-ibm-scc-da/main/images/scc-icon.svg",
2828
"provider_name": "IBM",
@@ -45,7 +45,7 @@
4545
{
4646
"label": "Instances",
4747
"name": "instances",
48-
"install_type": "extension",
48+
"install_type": "fullstack",
4949
"working_directory": "solutions/instances",
5050
"compliance": {
5151
"authority": "scc-v3",
@@ -90,7 +90,7 @@
9090
{
9191
"key": "prefix",
9292
"required": true,
93-
"description": "The prefix to add to all resources that this solution creates. To not use any prefix value, you can enter the string `__NULL__`."
93+
"description": "The prefix to add to all resources that this solution creates (e.g `prod`, `test`, `dev`). To not use any prefix value, you can enter the string `__NULL__`."
9494
},
9595
{
9696
"key": "existing_monitoring_crn",
@@ -274,6 +274,10 @@
274274
"key": "en_source_name",
275275
"required": false
276276
},
277+
{
278+
"key": "en_source_description",
279+
"required": false
280+
},
277281
{
278282
"key": "scc_instance_tags",
279283
"required": false
@@ -347,7 +351,7 @@
347351
"required": false
348352
},
349353
{
350-
"key": "existing_activity_tracker_crn",
354+
"key": "ibmcloud_kms_api_key",
351355
"required": false
352356
},
353357
{
@@ -361,6 +365,10 @@
361365
{
362366
"key": "scc_en_reply_to_email",
363367
"required": false
368+
},
369+
{
370+
"key": "cbr_rules",
371+
"required": false
364372
}
365373
],
366374
"iam_permissions": [
@@ -420,11 +428,19 @@
420428
"standard"
421429
],
422430
"catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3",
431+
"ignore_auto_referencing": [
432+
"*"
433+
],
423434
"input_mapping": [
424435
{
425436
"dependency_output": "kms_instance_crn",
426437
"version_input": "existing_kms_instance_crn"
427438
},
439+
{
440+
"dependency_input": "prefix",
441+
"version_input": "prefix",
442+
"reference_version": true
443+
},
428444
{
429445
"dependency_input": "region",
430446
"version_input": "scc_region",
@@ -442,6 +458,9 @@
442458
"standard"
443459
],
444460
"id": "63641cec-6093-4b4f-b7b0-98d2f4185cd6-global",
461+
"ignore_auto_referencing": [
462+
"*"
463+
],
445464
"input_mapping": [
446465
{
447466
"dependency_output": "audit_resource_group_name",
@@ -450,11 +469,16 @@
450469
{
451470
"version_input": "use_existing_resource_group",
452471
"value": true
472+
},
473+
{
474+
"dependency_input": "prefix",
475+
"version_input": "prefix",
476+
"reference_version": true
453477
}
454478
],
455479
"optional": true,
456480
"on_by_default": true,
457-
"version": "^1.11.6"
481+
"version": "^v1.18.2"
458482
},
459483
{
460484
"name": "testing-deploy-arch-ibm-event-notifications",
@@ -472,31 +496,49 @@
472496
"dependency_input": "region",
473497
"version_input": "scc_region",
474498
"reference_version": true
499+
},
500+
{
501+
"dependency_input": "prefix",
502+
"version_input": "prefix",
503+
"reference_version": true
475504
}
476505
],
506+
"ignore_auto_referencing": [
507+
"*"
508+
],
477509
"optional": true,
478510
"on_by_default": true,
479-
"version": "^1.0.1"
511+
"version": "^1.0.8"
480512
},
481513
{
482514
"name": "testing-deploy-arch-ibm-observability",
483515
"flavors": [
484-
"instances"
516+
"standard"
485517
],
486518
"id": "daf2cf91-2384-4205-b7f4-621299a4896d-global",
487519
"catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3",
488-
"input_mapping": [{
489-
"dependency_output": "cloud_monitoring_crn",
490-
"version_input": "existing_monitoring_crn"
491-
},
492-
{
493-
"dependency_input": "region",
494-
"version_input": "scc_region",
495-
"reference_version": true
496-
}],
520+
"input_mapping": [
521+
{
522+
"dependency_output": "cloud_monitoring_crn",
523+
"version_input": "existing_monitoring_crn"
524+
},
525+
{
526+
"dependency_input": "region",
527+
"version_input": "scc_region",
528+
"reference_version": true
529+
},
530+
{
531+
"dependency_input": "prefix",
532+
"version_input": "prefix",
533+
"reference_version": true
534+
}
535+
],
536+
"ignore_auto_referencing": [
537+
"*"
538+
],
497539
"optional": true,
498540
"on_by_default": true,
499-
"version": "^1.0.7"
541+
"version": "^1.3.0"
500542
}
501543
],
502544
"dependency_version_2": true

reference-architecture/scc-wp-agent.svg

-4
This file was deleted.

solutions/agents/README.md

-10
This file was deleted.

solutions/agents/catalogValidationValues.json.template

-3
This file was deleted.

solutions/agents/kubeconfig/.gitignore

-6
This file was deleted.

solutions/agents/kubeconfig/README.md

-2
This file was deleted.

solutions/agents/main.tf

-44
This file was deleted.

solutions/agents/outputs.tf

-8
This file was deleted.

solutions/agents/provider.tf

-44
This file was deleted.

0 commit comments

Comments
 (0)