Skip to content

fix(deps): update key-protect-all-inclusive to kms #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Conversation

MatthewLemmond
Copy link
Member

Description

Update the reference in the example for key-protect-all-inclusive to kms-all-inclusive

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

From #385, looks like the changes in that PR got overwritten and it was closed, example still using key-protect name so remade the PR

@MatthewLemmond
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Jun 6, 2024

A few errors:

Error: [0m Error: [ERROR] Error downloading the cluster config [cpgqnrhr0s0cbtktsl10]: Request failed with status code: 500, ServerErrorResponse: Error: lookup of user for "IAM:IBMid-666000KAO3" failed: useridentitymapping.user.openshift.io "IAM:IBMid-666000KAO3" not found
│ 
│   with module.ocp_base.data.ibm_container_cluster_config.cluster_config[0],
│   on ../../main.tf line 259, in data "ibm_container_cluster_config" "cluster_config":
│  259: data "ibm_container_cluster_config" "cluster_config" {
│ 
│ ---
│ id: terraform-82a5043b
Error: [0m summary: '[ERROR] Error downloading the cluster config
│ [cpgqnrhr0s0cbtktsl10]: Request
│   failed with status code: 500, ServerErrorResponse: Error: lookup of user for "IAM:IBMid-666000KAO3"
│   failed: useridentitymapping.user.openshift.io "IAM:IBMid-666000KAO3" not found'
│ severity: error
│ resource: (Data) ibm_container_cluster_config
│ operation: read
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.66.0
│ ---
│ 
╵
╷
Error: [0m Error: [ERROR] Error waiting for workerpool (cpgqnrhr0s0cbtktsl10/cpgqnrhr0s0cbtktsl10-46dbf63) to become ready: timeout while waiting for state to become 'deployed' (last state: 'provision_pending', timeout: 1h30m0s)
│ 
│   with module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool["zone-3"],
│   on ../../main.tf line 326, in resource "ibm_container_vpc_worker_pool" "autoscaling_pool":
│  326: resource "ibm_container_vpc_worker_pool" "autoscaling_pool" {
│ 
│ ---
│ id: terraform-4b844566
Error: [0m summary: '[ERROR] Error waiting for workerpool
│ (cpgqnrhr0s0cbtktsl10/cpgqnrhr0s0cbtktsl10-46dbf63)
│   to become ready: timeout while waiting for state to become ''deployed'' (last state:
│   ''provision_pending'', timeout: 1h30m0s)'
│ severity: error
│ resource: ibm_container_vpc_worker_pool
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.66.0
│ ---
│ 
╵}

Going to retry..

@ocofaigh
Copy link
Contributor

ocofaigh commented Jun 6, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 9f24565 into main Jun 7, 2024
@ocofaigh ocofaigh deleted the kp-to-kms-all-inc branch June 7, 2024 08:16
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants